svn commit: r1131297 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js

[hl...@apache.org]

Author: hlship
Date: Sat Jun  4 00:17:48 2011
New Revision: 1131297

URL: http://svn.apache.org/viewvc?rev=1131297&view=rev
Log:
TAP5-1539: Optimize document scans used by Tapestry.FieldEventManager to not locate the label or icon until actually needed

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?rev=1131297&r1=1131296&r2=1131297&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js Sat Jun  4 00:17:48 2011
@@ -1667,13 +1667,6 @@ Tapestry.FieldEventManager = Class.creat
 	initialize : function(field) {
 		this.field = $(field);
 
-		var id = this.field.id;
-
-		var selector = "label[for='" + id + "']";
-
-		this.label = this.field.up("form").down(selector);
-		this.icon = $(id + '_icon');
-
 		this.translator = Prototype.K;
 
 		var fem = $(this.field.form).getFormEventManager();
@@ -1699,6 +1692,23 @@ Tapestry.FieldEventManager = Class.creat
 		}
 	},
 
+	getLabel : function() {
+		if (!this.label) {
+			var selector = "label[for='" + this.field.id + "']";
+			this.label = this.field.form.down(selector);
+		}
+
+		return this.label;
+	},
+
+	getIcon : function() {
+		if (!this.icon) {
+			this.com = $(this.field.id + "_icon");
+		}
+
+		return this.icon;
+	},
+
 	/**
 	 * Removes validation decorations if present. Hides the ErrorPopup, if it
 	 * exists.
@@ -1706,11 +1716,9 @@ Tapestry.FieldEventManager = Class.creat
 	removeDecorations : function() {
 		this.field.removeClassName("t-error");
 
-		if (this.label)
-			this.label.removeClassName("t-error");
+		this.getLabel() && this.getLabel().removeClassName("t-error");
 
-		if (this.icon)
-			this.icon.hide();
+		this.getIcon() && this.getIcon().hide();
 
 		if (this.errorPopup)
 			this.errorPopup.hide();
@@ -1730,12 +1738,12 @@ Tapestry.FieldEventManager = Class.creat
 
 		this.field.addClassName("t-error");
 
-		if (this.label)
-			this.label.addClassName("t-error");
+		this.getLabel() && this.getLabel().addClassName("t-error");
+
+		var icon = this.getIcon();
 
-		if (this.icon) {
-			if (!this.icon.visible())
-				new Effect.Appear(this.icon);
+		if (icon && !icon.visible()) {
+			new Effect.Appear(this.icon);
 		}
 
 		if (this.errorPopup == undefined)