You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/03/02 15:24:48 UTC

[GitHub] zeppelin pull request #2827: [HOTFIX] fix checkstyle errors

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2827

    [HOTFIX] fix checkstyle errors

    ### What is this PR for?
    There are some checkstyle errors in branch-0.8, this is to fix all those errors.
    
    ### What type of PR is it?
    [Hot Fix]
    
    
    ### How should this be tested?
    * CI should be green.
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin hotfix/branch-0.8_checkstyle_errors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2827
    
----
commit 1c94e5cd9d81ae18861b375056db74f5dfe36597
Author: Prabhjyot Singh <pr...@...>
Date:   2018-03-02T15:22:20Z

    fix checkstyle errors
    
    Change-Id: I0b24f9287f4a8d63d18d55863505370b70c3659f

----


---

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2827
  
    @r-kamath @zjffdu  Please help review this.


---

[GitHub] zeppelin pull request #2827: [HOTFIX] fix checkstyle errors

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh closed the pull request at:

    https://github.com/apache/zeppelin/pull/2827


---

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2827
  
    @zjffdu sure, no problem.


---

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2827
  
    Thanks @prabhjyotsingh , I have already started one hotfix PR for building issue of branch-0.8, there's more issues except code style, do you mind to close this PR and I will fix it in one PR.
    
    https://github.com/zjffdu/zeppelin/commit/0ef79d1807599d2fbc74e8eeb3e18d0997aa7b85


---

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2827
  
    LGTM


---