You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/13 18:23:49 UTC
Review Request 21380: CLOUDSTACK-6612: Resolved issue with sshClient.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21380/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-6618
https://issues.apache.org/jira/browse/CLOUDSTACK-6618
Repository: cloudstack-git
Description
-------
Fixing issues in SSHClient and config.
1) Public port for natrule was 2222, it should be 22.
2) RetriesCount and delay in sshClient was defaulted to 0, it should be read from incoming parameters.
3) Indetation of "return" statement was wrong, due to which it was returning in first attempt itself without going for maximum no. of retry counts.
Diffs
-----
test/integration/smoke/test_network.py 6beb071
tools/marvin/marvin/config/test_data.py 7001c42
tools/marvin/marvin/sshClient.py 76f3b6d
Diff: https://reviews.apache.org/r/21380/diff/
Testing
-------
Yes.
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... SKIP: skip
----------------------------------------------------------------------
Ran 2 tests in 1922.008s
OK (SKIP=1)
Thanks,
Gaurav Aradhye
Re: Review Request 21380: CLOUDSTACK-6612: Resolved issue with sshClient.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21380/#review43348
-----------------------------------------------------------
Commit f2ebfe019e1ead6172712ec804b241cf0dc5a800 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f2ebfe0 ]
CLOUDSTACK-6612: Resolved issue with sshClient.py
- ASF Subversion and Git Services
On May 19, 2014, 8:20 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21380/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 8:20 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6618
> https://issues.apache.org/jira/browse/CLOUDSTACK-6618
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing issues in SSHClient and config.
>
> 1) Public port for natrule was 2222, it should be 22.
> 2) Indetation of "return" statement was wrong (Look at line no. 157), due to which it was returning in first attempt itself without going for maximum no. of retry counts.
> 3) Removed unused imports
>
>
> Diffs
> -----
>
> tools/marvin/marvin/config/test_data.py 026f5ff
> tools/marvin/marvin/sshClient.py 76f3b6d
>
> Diff: https://reviews.apache.org/r/21380/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> Test for port forwarding on non source NAT ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 2 tests in 1922.008s
>
> OK (SKIP=1)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21380: CLOUDSTACK-6612: Resolved issue with sshClient.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21380/#review43349
-----------------------------------------------------------
Commit 89b041a62d99d07b7c5d5b7b49bda3630f9559dd in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=89b041a ]
CLOUDSTACK-6612: Resolved issue with sshClient.py
- ASF Subversion and Git Services
On May 19, 2014, 8:20 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21380/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 8:20 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6618
> https://issues.apache.org/jira/browse/CLOUDSTACK-6618
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing issues in SSHClient and config.
>
> 1) Public port for natrule was 2222, it should be 22.
> 2) Indetation of "return" statement was wrong (Look at line no. 157), due to which it was returning in first attempt itself without going for maximum no. of retry counts.
> 3) Removed unused imports
>
>
> Diffs
> -----
>
> tools/marvin/marvin/config/test_data.py 026f5ff
> tools/marvin/marvin/sshClient.py 76f3b6d
>
> Diff: https://reviews.apache.org/r/21380/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> Test for port forwarding on non source NAT ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 2 tests in 1922.008s
>
> OK (SKIP=1)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21380: CLOUDSTACK-6612: Resolved issue with sshClient.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21380/#review43344
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 19, 2014, 8:20 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21380/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 8:20 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6618
> https://issues.apache.org/jira/browse/CLOUDSTACK-6618
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing issues in SSHClient and config.
>
> 1) Public port for natrule was 2222, it should be 22.
> 2) Indetation of "return" statement was wrong (Look at line no. 157), due to which it was returning in first attempt itself without going for maximum no. of retry counts.
> 3) Removed unused imports
>
>
> Diffs
> -----
>
> tools/marvin/marvin/config/test_data.py 026f5ff
> tools/marvin/marvin/sshClient.py 76f3b6d
>
> Diff: https://reviews.apache.org/r/21380/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> Test for port forwarding on non source NAT ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 2 tests in 1922.008s
>
> OK (SKIP=1)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21380: CLOUDSTACK-6612: Resolved issue with sshClient.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21380/
-----------------------------------------------------------
(Updated May 19, 2014, 1:50 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Updated request with rebased patch. Santhosh, can you please review this?
Bugs: CLOUDSTACK-6618
https://issues.apache.org/jira/browse/CLOUDSTACK-6618
Repository: cloudstack-git
Description (updated)
-------
Fixing issues in SSHClient and config.
1) Public port for natrule was 2222, it should be 22.
2) Indetation of "return" statement was wrong (Look at line no. 157), due to which it was returning in first attempt itself without going for maximum no. of retry counts.
3) Removed unused imports
Diffs (updated)
-----
tools/marvin/marvin/config/test_data.py 026f5ff
tools/marvin/marvin/sshClient.py 76f3b6d
Diff: https://reviews.apache.org/r/21380/diff/
Testing
-------
Yes.
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... SKIP: skip
----------------------------------------------------------------------
Ran 2 tests in 1922.008s
OK (SKIP=1)
Thanks,
Gaurav Aradhye