You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/07/17 21:56:01 UTC
Review Request 36580: Added TaskStatus label decorator hook for Slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This allows Slave modules to expose some information to the frameworks
as well as Mesos-DNS via state.json.
Diffs
-----
include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f
src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab
src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc
src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
Diff: https://reviews.apache.org/r/36580/diff/
Testing
-------
make check with a new hook test.
Thanks,
Kapil Arya
Re: Review Request 36580: Added TaskStatus label decorator hook for
Master/Slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/
-----------------------------------------------------------
(Updated July 19, 2015, 12:43 a.m.)
Review request for mesos.
Changes
-------
added master hooks as well.
Summary (updated)
-----------------
Added TaskStatus label decorator hook for Master/Slave.
Repository: mesos
Description (updated)
-------
This allows Master/Slave modules to expose some information to the
frameworks as well as Mesos-DNS via state.json.
Diffs (updated)
-----
include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f
src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab
src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc
src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
Diff: https://reviews.apache.org/r/36580/diff/
Testing
-------
make check with a new hook test.
Thanks,
Kapil Arya
Re: Review Request 36580: Added TaskStatus label decorator hook for
Slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/
-----------------------------------------------------------
(Updated July 18, 2015, 8:38 p.m.)
Review request for mesos.
Changes
-------
rebased
Repository: mesos
Description
-------
This allows Slave modules to expose some information to the frameworks
as well as Mesos-DNS via state.json.
Diffs (updated)
-----
include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f
src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab
src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc
src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
Diff: https://reviews.apache.org/r/36580/diff/
Testing
-------
make check with a new hook test.
Thanks,
Kapil Arya
Re: Review Request 36580: Added TaskStatus label decorator hook for
Slave.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/#review92123
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36574, 36575, 36580]
All tests passed.
- Mesos ReviewBot
On July 17, 2015, 7:56 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36580/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 7:56 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows Slave modules to expose some information to the frameworks
> as well as Mesos-DNS via state.json.
>
>
> Diffs
> -----
>
> include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f
> src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab
> src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc
> src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
> src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
> src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
>
> Diff: https://reviews.apache.org/r/36580/diff/
>
>
> Testing
> -------
>
> make check with a new hook test.
>
>
> Thanks,
>
> Kapil Arya
>
>