[GitHub] [skywalking] wu-sheng commented on a change in pull request #7032: kafka transporter code polish

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7032:
URL: https://github.com/apache/skywalking/pull/7032#discussion_r641065688



##########
File path: apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
##########
@@ -142,16 +142,6 @@ private void notifyListeners(KafkaConnectionStatus status) {
         }
     }
 
-    private void closeAdminClient(AdminClient adminClient) {
-        if (adminClient != null) {
-            try {
-                adminClient.close();
-            } catch (Exception e) {
-                LOGGER.error("close kafka admin client failed", e);
-            }
-        }
-    }
-

Review comment:
       What happened? Why removing this? Read #7016. If you want any concerns, we should loop @darcydai in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org