[GitHub] [iotdb] Beyyes commented on a diff in pull request #7497: [IOTDB-4568] Added test api for partitions

[GitBox <gi...@apache.org>]

Beyyes commented on code in PR #7497:
URL: https://github.com/apache/iotdb/pull/7497#discussion_r989253811


##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -613,4 +619,22 @@ public TSStatus dropPipeSink(TDropPipeSinkReq req) throws TException {
   public TGetPipeSinkResp getPipeSink(TGetPipeSinkReq req) throws TException {
     return configManager.getPipeSink(req);
   }
+
+  @Override
+  @TestOnly

Review Comment:
   Maybe we can remove `TestOnly` annotation. We will implement the corresponding sql later.



##########
node-commons/src/main/java/org/apache/iotdb/commons/path/PartialPath.java:
##########
@@ -63,7 +63,6 @@ public PartialPath() {}
    * = "root.sg.`d.1`.`s.1`" nodes = {"root", "sg", "`d.1`", "`s.1`"}
    *
    * @param path a full String of a time series path
-   * @throws IllegalPathException

Review Comment:
   why remove it 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org