[GitHub] [solr] janhoy commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

[GitBox <gi...@apache.org>]

janhoy commented on code in PR #889:
URL: https://github.com/apache/solr/pull/889#discussion_r887635013


##########
solr/solr-ref-guide/modules/configuration-guide/pages/configuring-solr-xml.adoc:
##########
@@ -183,9 +183,9 @@ Note that specifying `sharedLib` will not remove `$SOLR_HOME/lib` from Solr's cl
 |Optional |Default: none
 |===
 +
-Takes a list of bundled xref:solr-modules.adoc[solr modules] to add to Solr's class path
+Takes a list of bundled xref:solr-modules.adoc[Solr Modules] to enabled

Review Comment:
   ```suggestion
   Takes a list of bundled xref:solr-modules.adoc[Solr Modules] to enable
   ```



##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-7.adoc:
##########
@@ -230,7 +230,7 @@ Mentions of deprecations are likely superseded by removal in Solr 7, as noted in
 
 Note again that this is not a complete list of all changes that may impact your installation, so a thorough review of CHANGES.txt is highly recommended if upgrading from any version earlier than 6.6.
 
-* The Solr modules `map-reduce`, `morphlines-core` and `morphlines-cell` have been removed.
+* The Solr Modules `map-reduce`, `morphlines-core` and `morphlines-cell` have been removed.

Review Comment:
   Hmm, historic release notes should probably not be changed. This was probably an oversight in 9.0 while bulk search/replacing `s/contrib/module/`. See https://solr.apache.org/guide/8_6/major-changes-in-solr-7.html#major-changes-in-earlier-6-x-versions for original text.
   ```suggestion
   * The Solr contribs `map-reduce`, `morphlines-core` and `morphlines-cell` have been removed.
   ```



##########
solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc:
##########
@@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses Javaagen
 The `modules/jagertracer-configurator` provides a default implementation for setting up Jaeger Tracer.
 
 Add the solr-jaegertracer JAR file and the other JARs provided with this module to your Solr installation, ideally to each node.
-GSON is a dependency that is only used by Jaeger's "remote" sampler,
+https://github.com/google/gson[GSON] is a dependency that is only used by Jaeger's "remote" sampler,

Review Comment:
   Curious - what's the reason behind not making GSON a module-local dependency and thus include in lib/?



##########
solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml:
##########
@@ -69,8 +69,10 @@
        If a 'dir' option (with or without a regex) is used and nothing
        is found that matches, a warning will be logged.
 
-       The examples below can be used to load some solr modules along
-       with their external dependencies.
+       The examples below can be used to load some Solr Modules along
+       with their external dependencies as an alternative to using a
+       startup parameter to define the modules to load.  For more info

Review Comment:
   ```suggestion
          startup parameter to define the modules to load globally.  For more info
   ```



##########
solr/solr-ref-guide/modules/query-guide/pages/learning-to-rank.adoc:
##########
@@ -113,7 +113,7 @@ In the form of JSON files your trained model or models (e.g., different models f
 
 == Quick Start with LTR
 
-The `"techproducts"` example included with Solr is pre-configured with the plugins required for learning-to-rank, but they are disabled by default.
+The `"techproducts"` example included with Solr is pre-configured with the `ltr` module and plugins required for learning-to-rank, but they are disabled by default.

Review Comment:
   To be precise, there is no way to load a **module** from solrconfig.xml, but you can load all the jars in a module's `lib/` folder, thus enabling all that modules' plugins.
   ```suggestion
   The `"techproducts"` example included with Solr is pre-configured to load the plugins required for learning-to-rank from the `ltr` module, but they are disabled by default.
   ```



##########
solr/solr-ref-guide/modules/indexing-guide/pages/language-analysis.adoc:
##########
@@ -692,16 +692,16 @@ On the other hand, it can reduce precision because language-specific character d
 
 == OpenNLP Integration
 
-The `lucene/analysis/opennlp` module provides OpenNLP integration via several analysis components: a tokenizer, a part-of-speech tagging filter, a phrase chunking filter, and a lemmatization filter.
+The `lucene/analysis/opennlp` package provides OpenNLP integration via several analysis components: a tokenizer, a part-of-speech tagging filter, a phrase chunking filter, and a lemmatization filter.

Review Comment:
   ```suggestion
   The Lucene-Module `lucene/analysis/opennlp` provides OpenNLP integration via several analysis components: a tokenizer, a part-of-speech tagging filter, a phrase chunking filter, and a lemmatization filter.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org