[GitHub] [pdfbox] gunnar-ifp commented on pull request #122: Update SampledImageReader.java

[GitBox <gi...@apache.org>]

gunnar-ifp commented on pull request #122:
URL: https://github.com/apache/pdfbox/pull/122#issuecomment-864996142


   Yeah as I wrote in the initial comment, it's not really slow. I simply timed the method itself in the sourcecode with System nanoseconds and for the big mask it went down from 55 to something 25ish. Once you go through a few pages of that Alfa catalog PDF you can see consisten times. As I said it wasn't really slow. It was just very wasteful in the original version with not calculating start offsets and all.
   
   And the error if readLen!=rowLen was not caught with subsampling if the line was left out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org