You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Tanner Clary (Jira)" <ji...@apache.org> on 2023/04/27 16:39:00 UTC
[jira] [Updated] (CALCITE-5677) Use comma-separated arguments in BigQuery SUBSTR
[ https://issues.apache.org/jira/browse/CALCITE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanner Clary updated CALCITE-5677:
----------------------------------
Description:
BigQuery's {{SUBSTR(value, position[, length])}} function currently gets translated to the standard {{SUBSTRING(value FROM position[ FOR length])}}. BigQuery expects the arguments to be comma-separated rather than the use of the {{FROM}} and {{FOR}} keywords.
EXAMPLE: {{SUBSTR('hello', 2)}} would get translated to {{SUBSTRING('hello' FROM 2)}} which BigQuery does not recognize.
Hive addresses this issue by adding onto {{HiveSqlDialect#unparseCall}} method. I believe BigQuery should do something similar to avoid this incorrect translation. The docs for the {{SUBSTR}} (and alias {{SUBSTRING}}) function may be found [here|https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#substr].
I will open a PR shortly that implements my suggestion and adds a couple of tests as well.
was:
BigQuery's {{SUBSTR(value, position[, length])}} function currently gets translated to the standard {{SUBSTRING(value FROM position[ FOR length])]}. BigQuery expects the arguments to be comma-separated rather than the use of the {{FROM}} and {{FOR}} keywords.
EXAMPLE: {{SUBSTR('hello', 2)}} would get translated to {{SUBSTRING('hello' FROM 2)}} which BigQuery does not recognize.
Hive addresses this issue by adding onto {{HiveSqlDialect#unparseCall}} method. I believe BigQuery should do something similar to avoid this incorrect translation. The docs for the {{SUBSTR}} (and alias {{SUBSTRING}}) function may be found [here|https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#substr].
I will open a PR shortly that implements my suggestion and adds a couple of tests as well.
> Use comma-separated arguments in BigQuery SUBSTR
> ------------------------------------------------
>
> Key: CALCITE-5677
> URL: https://issues.apache.org/jira/browse/CALCITE-5677
> Project: Calcite
> Issue Type: Bug
> Reporter: Tanner Clary
> Assignee: Tanner Clary
> Priority: Major
> Labels: pull-request-available
>
> BigQuery's {{SUBSTR(value, position[, length])}} function currently gets translated to the standard {{SUBSTRING(value FROM position[ FOR length])}}. BigQuery expects the arguments to be comma-separated rather than the use of the {{FROM}} and {{FOR}} keywords.
> EXAMPLE: {{SUBSTR('hello', 2)}} would get translated to {{SUBSTRING('hello' FROM 2)}} which BigQuery does not recognize.
> Hive addresses this issue by adding onto {{HiveSqlDialect#unparseCall}} method. I believe BigQuery should do something similar to avoid this incorrect translation. The docs for the {{SUBSTR}} (and alias {{SUBSTRING}}) function may be found [here|https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#substr].
> I will open a PR shortly that implements my suggestion and adds a couple of tests as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)