You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/28 16:21:57 UTC
[GitHub] [incubator-devlake] Startrekzky opened a new issue, #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Startrekzky opened a new issue, #3243:
URL: https://github.com/apache/incubator-devlake/issues/3243
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
### What you expected to happen
The cursor should stick to the top of the transformation page.
### How to reproduce
1. create a blueprint and select a github connection
2. click 'Add Transformation'
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Posted by GitBox <gi...@apache.org>.
mintsweet commented on issue #3243:
URL: https://github.com/apache/incubator-devlake/issues/3243#issuecomment-1261660233
I will fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3243:
URL: https://github.com/apache/incubator-devlake/issues/3243#issuecomment-1261482250
@likyh @mintsweet If one of you is interested in resolving this, the easiest path would be to patch all the `settings/[provider].jsx` transformation partials so that the `tabIndex` attribute is specified for all _applicable_ form controls starting at the top with `tabIndex={0}` then `tabIndex={1}` etc. Alternatively a `ref` could be used on just the first input on each corresponding transformation setting file, and then focus could be enforced programmatically with JS, but this route may incur more code changes.
I think Option 1 with applying `tabIndex` property would be the safe route to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #3243:
URL: https://github.com/apache/incubator-devlake/issues/3243#issuecomment-1263350382
Verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3243:
URL: https://github.com/apache/incubator-devlake/issues/3243#issuecomment-1261485542
The other thing if note is that _Deployment_ transformation settings are shared too, and _conditional_ so those inputs should also receive `tabIndex` props. Create a Blueprint with ALL Data Entities selected so all transformation settings are in view, and then assign the Tab Indexes based on that render in terms of ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3243:
URL: https://github.com/apache/incubator-devlake/issues/3243#issuecomment-1261165709
There may not be explicit `TabIndex` attributes set for the inputs to dictate which input can get focused first, so this textarea maybe the unintended default of what's being focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh closed issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
Posted by GitBox <gi...@apache.org>.
likyh closed issue #3243: [Bug][config-ui] Click 'Add Transformation' for a github connection, the cursor went to the wrong input
URL: https://github.com/apache/incubator-devlake/issues/3243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org