You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/04 19:07:36 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #17265: [BEAM-11104] Add ProcessContinuation type to Go SDK

damccorm commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r842056277


##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -631,6 +647,8 @@ func nextRetState(cur retState, transition ReturnKind) (retState, error) {
 		return -1, errEventTimeRetPrecedence
 	case RetValue, RetRTracker:
 		return rsOutput, nil
+	case RetProcessContinuation:
+		return rsProcessContinuation, nil

Review Comment:
   From a technical standpoint this LGTM, I'm not so sure about the ordering of the changes though. Specifically, what I'm worried about is the potential for:
   
   1) This PR takes away the validation that says you can't have a ProcessContinuation type as a return type.
   2) The Sdk gets cut/released with version X.
   3) This PR gets completed and we doc the change for version Y.
   4) A user still on version X sees the doc changes and tries to use the ProcessContinuation, getting an error at pipeline run time (or even worse, silently seeing no errors)
   
   While I'm 100% all about breaking PRs up, as a rule I would prefer we don't expose the user facing API until the last incremental PR so that we avoid the potential for something like that happening. Basically, I don't want to _expose_ any incomplete features.
   
   I would prefer we get rid of these 2 lines (or at least comment them out) so that there is no ambiguity about what is supported and users get a pipeline construction time error indicating exactly what the problem is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org