You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/02 15:12:03 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
codecov-io commented on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `1.52%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 62.64% +1.52%
==========================================
Files 801 878 +77
Lines 37754 46639 +8885
Branches 3555 6283 +2728
==========================================
+ Hits 23075 29218 +6143
- Misses 14493 17169 +2676
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `60.83% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.38% <50.00%> (-0.11%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `56.98% <0.00%> (-7.88%)` | :arrow_down: |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | `75.00% <0.00%> (-6.82%)` | :arrow_down: |
| ... and [283 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org