You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/01 01:02:57 UTC
Re: Review Request 71213: Updated operator HTTP API documentation
regarding `UPDATE_QUOTA`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71213/
-----------------------------------------------------------
(Updated July 31, 2019, 6:02 p.m.)
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Changes
-------
Addressed Andrei's comment.
Repository: mesos
Description
-------
The deprecated calls `SET_QUOTA` and `REMOVE_QUOTA` are
now hidden.
Diffs (updated)
-----
docs/operator-http-api.md ddf29e9e29dcf9d0801118382402be5945d8117d
Diff: https://reviews.apache.org/r/71213/diff/2/
Changes: https://reviews.apache.org/r/71213/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71213: Updated operator HTTP API documentation
regarding `UPDATE_QUOTA`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71213/#review217079
-----------------------------------------------------------
Fix it, then Ship it!
docs/operator-http-api.md
Line 2457 (original), 2457 (patched)
<https://reviews.apache.org/r/71213/#comment304339>
to be clear it's one or more, how about: "the quota for the specified role(s)"
docs/operator-http-api.md
Line 2470 (original), 2473 (patched)
<https://reviews.apache.org/r/71213/#comment304340>
can you keep the space after the : character for all these lines?
docs/operator-http-api.md
Lines 2476-2480 (original), 2478-2493 (patched)
<https://reviews.apache.org/r/71213/#comment304342>
Seems more readable like the following?
```
"guarantees": {
"cpus": { "value": 1.0 },
"mem": { "value": 1024.0}
},
"limits": {
"cpus": { "value": 2.0 },
"mem": { "value": 2048.0 }
}
```
(note I added back the spaces after the : characters)
- Benjamin Mahler
On Aug. 1, 2019, 1:02 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71213/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2019, 1:02 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The deprecated calls `SET_QUOTA` and `REMOVE_QUOTA` are
> now hidden.
>
>
> Diffs
> -----
>
> docs/operator-http-api.md ddf29e9e29dcf9d0801118382402be5945d8117d
>
>
> Diff: https://reviews.apache.org/r/71213/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>