You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/17 03:17:12 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Superskyyy opened a new pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165
All tests except Sanic is passing in GHA.
Sanic with `sw-python run` fails for Python 3.6 but not 3.7 -> 3.9, - https://github.com/Superskyyy/skywalking-python/runs/3625969357?check_suite_focus=true
sanic/provider.py reporting a exit span from 7002(requests) instead of entry span from 7007(sanic), still trying to figure out why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921426009
kept the original Sanic tests untouched for latest commit, so the CI will pass here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921428038
From the actual data it seems that one of the services (provider, consumer) failed to report data to backend, 2 segments from each service respectively are expected while there is only one from one service. Did it consistently fail or did it ever succeed?
might it be the agent failed to send pending data when the application exit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921428038
From the actual data it seems that one of the services (provider, consumer) failed to report data to backend, 2 segments from each respectively are expected while there is only one from one service. Did it consistently fail or did it ever succeed?
might it be the agent failed to send pending data when the application exit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921447308
> From the actual data it seems that one of the services (provider, consumer) failed to report data to backend, 2 segments from each respectively are expected while there is only one from one service. Did it consistently fail or did it ever succeed?
>
> might it be the agent failed to send pending data when the application exit?
It was a consistent failure for CLI based and always succeeds for the original. Just tested more times on my another branch.
I'm trying to figure out what's the difference I missed between the two testing methods and how it only impacts Python 3.6 zzz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921457250
> Guess I'll need to make a local Sanic project and bring it up with sw-python at Python 3.6 for an actual oap to see if anything weird happens.
>
For the sake of convenience, consider using the OAP docker image to start an oap instance, and you can just start the Sanic project used in the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921428038
From the actual data it seems that one of the services (provider, consumer) failed to report data to backend, 2 segments from each service respectively are expected while there is only one from one service. Did it consistently fail or did it ever succeed?
might it be the agent failed to send pending data when the application exit? (We fixed this before but not sure whether sw-python CLI brings this issue back)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy edited a comment on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
Superskyyy edited a comment on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921454240
Guess I'll need to make a local Sanic project and bring it up with sw-python at Python 3.6 for an actual oap to see if anything weird happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921529618
> > Guess I'll need to make a local Sanic project and bring it up with sw-python at Python 3.6 for an actual oap to see if anything weird happens.
>
> For the sake of convenience, consider using the OAP docker image to start an oap instance, and you can just start the Sanic project used in the tests?
Good news, issue found and fixed(I hope).
The root problem comes from the `from sys import argv` that Sanic uses inside its own code. When the import fails, the `sw_sanic` plugin fails to install, which makes weird errors.
https://bugs.python.org/issue32573
Above mentions the particular limitation in Python 3.6(the bug report claims 3.7 too, but it seems to be working anyway), `sys.argv` is not set when the interpreter is invoked in a way like our CLI, so I applied the workaround to have it always importable.
```Python
if not hasattr(sys, 'argv'):
sys.argv = ['']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #165: Refactor SkyWalking Python to use the CLI for CI instead of legacy setup
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #165:
URL: https://github.com/apache/skywalking-python/pull/165#issuecomment-921454240
Guess I'll need to make a local Sanic project and bring it up with sw-Python at Python 3.6 for an actual oap to see if anything weird happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org