[jira] [Commented] (SLING-5152) JsonJcrNode and JsonItemWriter should use prop.isMultiple() instead of def.isMultiple()

["Joel Richard (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958918#comment-14958918 ] 

Joel Richard commented on SLING-5152:
-------------------------------------

I have created a pull request for this issue and SLING-5153: https://github.com/apache/sling/pull/107
[~rombert] or [~tomek.rekawek], would you mind reviewing the pull request?

> JsonJcrNode and JsonItemWriter should use prop.isMultiple() instead of def.isMultiple()
> ---------------------------------------------------------------------------------------
>
>                 Key: SLING-5152
>                 URL: https://issues.apache.org/jira/browse/SLING-5152
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons JSON 2.0.12
>            Reporter: Joel Richard
>            Priority: Minor
>              Labels: json, performance
>
> In Oak, node.getDefinition().isMultiple() is is around 35 times slower than prop.isMultiple(). In addition to this, MockProperty.isMultiple has to be implemented because otherwise the tests fail (for which I will open another issue shortly).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)