[GitHub] [lucene] uschindler commented on pull request #11999: Add support for stored fields to MemoryIndex

[GitBox <gi...@apache.org>]

uschindler commented on PR #11999:
URL: https://github.com/apache/lucene/pull/11999#issuecomment-1340615081

   Hi,
   I have no idea, what the reason for this issue/PR is (can I have a bit more information, is there an issue, too?), because MemoryIndex is mostly used for the old highlighting. I am fine to add stored fields to the MemoryIndex, but from my perspective the whole encoding looks useless: Why do we need to encode the stored contents at all into a byte[]? MemoryIndex only has one document and like terms, why not simply use a `Map<String,Object[]>` as datastore. `Object` can be any type here. To me it looks like an overhead to encode values on indexing and decode them, although the encoded values are never exposed.
   Merging MemoryIndex into another conventional index is no issue, as MemoryIndexReader does not implement CodecReader at all, so Bulk Merging won't work and merging will use the LeafReader interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org