[GitHub] [fineract] adamsaghy commented on a diff in pull request #3269: FINERACT-1926: Fineract Asset Externalization - Cancel

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3269:
URL: https://github.com/apache/fineract/pull/3269#discussion_r1238583543


##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersReadServiceImpl.java:
##########
@@ -120,6 +120,13 @@ public ExternalTransferData retrieveFirstTransferByExternalId(ExternalId externa
                 .orElseThrow(() -> new ExternalAssetOwnerTransferNotFoundException(externalTransferId));
     }
 
+    @Override
+    public Long retrieveFirstTransferIdByExternalId(ExternalId externalTransferId) {
+        return externalAssetOwnerTransferRepository.findFirstByExternalIdOrderByIdAsc(externalTransferId)

Review Comment:
   Would it make sense to find the latest? i dont really see the reason why to look for the first one... :/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org