[jira] [Commented] (MESOS-7658) apply-reviews.py fails with Unicode characters on Windows

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048497#comment-16048497 ] 

Andrew Schwartzmeyer commented on MESOS-7658:
---------------------------------------------

So, unfortunately, this is a problem with `subprocess` itself. I got around it erroring during the internal args.format it does when `shell=True` (by setting it to false), but it uses the short version of `CreateProcess`, so you get this anyway:

{code}
  File "C:\Python27\lib\subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Python27\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 640, in _execute_child
    startupinfo)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
{code}

It dies when making the (non-Unicode) startupinfo.

> apply-reviews.py fails with Unicode characters on Windows
> ---------------------------------------------------------
>
>                 Key: MESOS-7658
>                 URL: https://issues.apache.org/jira/browse/MESOS-7658
>             Project: Mesos
>          Issue Type: Bug
>         Environment: Windows 10
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>
> This prevents commits from being applied if the name or message contains non-ASCII characters, and so can break the Windows ReviewBot.
> {code}
> > git checkout b2801f0012535e29609f603b4324a9ca693f70cb~
> > python .\support\apply-reviews.py -r 59874
> Traceback (most recent call last):
>   File ".\support\apply-reviews.py", line 381, in <module>
>     reviewboard()
>   File ".\support\apply-reviews.py", line 360, in reviewboard
>     apply_review()
>   File ".\support\apply-reviews.py", line 126, in apply_review
>     commit_patch()
>   File ".\support\apply-reviews.py", line 225, in commit_patch
>     shell(cmd, options['dry_run'])
>   File ".\support\apply-reviews.py", line 111, in shell
>     error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
>   File "C:\Python27\lib\subprocess.py", line 168, in call
>     return Popen(*popenargs, **kwargs).wait()
>   File "C:\Python27\lib\subprocess.py", line 390, in __init__
>     errread, errwrite)
>   File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
>     args = '{} /c "{}"'.format (comspec, args)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
> ~\src\mesos-copy2 |-/
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)