[jira] [Comment Edited] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229258#comment-14229258 ] 

Andrew Purtell edited comment on HBASE-12581 at 11/30/14 10:06 PM:
-------------------------------------------------------------------

In most security tests involving the AccessController we create a table, wait for it to become ready, then grant perms on it using SecureTestUtil static methods, which will call SecureTestUtil#updateACLs to apply the grants. That method reaches in to the guts of the AccessControllers on the minicluster and waits for them all to acknowledge the change "broadcast" by znode write before returning. However as Ram correctly points out we don't have a SecureTestUtil#createTable, or similar, which could avoid racing around table create or truncate by waiting for all AC instances to acknowledge a perm cache update, hence the problem on this issue. Sorry about that. Also as mentioned above we should be able to do better than this someday with "ProcedureV2", or a notification bus, or an embedded consensus library. 


was (Author: apurtell):
In most security tests involving the AccessController we create a table, wait for it to become ready, then grant perms on it using SecureTestUtil static methods, which will call SecureTestUtil#updateACLs to apply the grants. That method reaches in to the guts of the AccessControllers on the minicluster and waits for them all to acknowledge the change "broadcast" by znode write before returning. However as Ram correctly points out we don't have a SecureTestUtil#createTable, or similar, which avoids racing around table create or truncate, hence the problem on this issue. Sorry about that. Also as mentioned above we should be able to do better than this someday with "ProcedureV2", or a notification bus, or an embedded consensus library. 

> TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-12581
>                 URL: https://issues.apache.org/jira/browse/HBASE-12581
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: 12581.addendum.sleep.txt, 12581.addendum.txt, 12581.txt, acls.txt
>
>
> TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it passed twice on hadoopqa!).  Fails locally too.  Here, make a Connection when we go to check perms.  That seems to fix it. Going to commit since patch is just more of hbase-12404... this is in essence and addendum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)