You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org> on 2005/08/15 08:58:57 UTC
[jira] Created: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
---------------------------------------------------------------------------------
Key: MPEJB-19
URL: http://jira.codehaus.org/browse/MPEJB-19
Project: maven-ejb-plugin
Type: Bug
Versions: 1.7
Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
Reporter: Fredrik Vraalsen
Attachments: ejb-client-name.patch
I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
Cheers,
Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=comments#action_44475 ]
Vincent Massol commented on MPEJB-19:
-------------------------------------
Fredrik,
Although I haven tried it you need a dependency of type 'ejb-client', not 'ejb':
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT</version>
<type>ejb-client</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
Let us know if it works.
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=comments#action_44482 ]
Fredrik Vraalsen commented on MPEJB-19:
---------------------------------------
Ok, so I got the following to work in Maven 1.1 beta 1 (the EAR now includes both jar files):
<dependencies>
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT</version>
<type>ejb</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT-client</version>
<type>ejb</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
</dependencies>
However, if I understood you correctly, for the latter dependency it _should_ have worked to use a version 1.0-SNAPSHOT (withouth the '-client') and a type 'ejb-client'? Maybe I need to upgrade some of the other plugins as well? (I had to upgrade the artifact plugin to v1.6 to fix some other bugs).
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=comments#action_44479 ]
Brett Porter commented on MPEJB-19:
-----------------------------------
unfortunately, Maven 1.0.2 doesn't allow more than one dep with a different type but the same id. Fixed in Maven 1.1 beta 1, as you've seen.
It's strange that the extension is wrong though - that appears to be an additional bug.
A workaround in 1.0.2 is to add -client to the version. Gross, but we need to keep the right format.
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Reopened: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=all ]
Fredrik Vraalsen reopened MPEJB-19:
-----------------------------------
In this case, I run into a problem because the ejb and ejb client files have the same artifact id, meaning that I cannot depend on both (Maven will choose the one with the highest version number).
Take for example this EAR project.xml file, which ends up not including the client jar since 1.0-SNAPSHOT is a higher version than 1.0-SNAPSHOT-client:
<?xml version='1.0' ?>
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/3.0.0" xsi:schemaLocation="http://maven.apache.org/POM/3.0.0 http://maven.apache.org/maven-v3_0_0.xsd">
<extend>${basedir}/../../project.xml</extend>
<groupId>sintef</groupId>
<artifactId>asset-repository-ear</artifactId>
<name>Asset repository EAR</name>
<currentVersion>1.0-SNAPSHOT</currentVersion>
<inceptionYear>2005</inceptionYear>
<dependencies>
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT</version>
<type>ejb</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT-client</version>
<type>ejb</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
</dependencies>
</project>
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=all ]
Fredrik Vraalsen updated MPEJB-19:
----------------------------------
Attachment: ejb-client-name-testcase.patch
Patch for testcase
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=all ]
Brett Porter closed MPEJB-19:
-----------------------------
Resolution: Won't Fix
reclosing as before.
you are right - 1.0-SNAPSHOT should work, but you must upgrade to Maven 1.1 beta 1 for that to work (it is in the core, not a plugin)
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=all ]
Brett Porter closed MPEJB-19:
-----------------------------
Assign To: Brett Porter
Resolution: Won't Fix
this is consistent with the m2 implementation.
client is a "classifier", coming after the version. It is much clearer there which part is the version and which is the classifier. Next to the artifactId, it is possibly more ambiguous.
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=comments#action_44890 ]
Vincent Massol commented on MPEJB-19:
-------------------------------------
Just to be clear: This is a bug in Maven 1.1. It won't work even if you build 1.1 from trunk. See MAVEN-1669.
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPEJB-19) EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPEJB-19?page=comments#action_44478 ]
Fredrik Vraalsen commented on MPEJB-19:
---------------------------------------
Ok, I tried to change my dependencies to
<dependencies>
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT</version>
<type>ejb</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
<dependency>
<groupId>sintef</groupId>
<artifactId>asset-repository-ejb</artifactId>
<version>1.0-SNAPSHOT</version>
<type>ejb-client</type>
<properties>
<ear.bundle>true</ear.bundle>
</properties>
</dependency>
</dependencies>
With Maven 1.0.2, it just ignores the ejb-client dependency:
[fvr@tcosl016 asset-repository-ear]$ maven ear
__ __
| \/ |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
|_| |_\__,_|\_/\___|_||_| v. 1.0.2
Forsøker å laste ned asset-repository-ejb-1.0-SNAPSHOT.jar.
Artifact /sintef/ejbs/asset-repository-ejb-1.0-SNAPSHOT.jar doesn't exists in remote repository, but it exists locally
build:start:
ear:init:
ear:ear:
[echo] Building EAR asset-repository-ear-1.0-SNAPSHOT with appxml "d:\eclipse\CorasTool-2.0-branch-work-maven\src\modules\asset-repository-ear/target/application.xml"
[echo] Bundling: ejb - sintef:asset-repository-ejb - 1.0-SNAPSHOT
[echo] Dependency asset-repository-ejb-1.0-SNAPSHOT.jar will be bundled as /asset-repository-ejb-1.0-SNAPSHOT.jar
[copy] Copying 1 file to D:\eclipse\CorasTool-2.0-branch-work-maven\src\modules\asset-repository-ear\target\tmpEarDeps
[ear] Building ear: D:\eclipse\CorasTool-2.0-branch-work-maven\src\modules\asset-repository-ear\target\asset-repository-ear-1.0-SNAPSHOT.ear
[delete] Deleting directory D:\eclipse\CorasTool-2.0-branch-work-maven\src\modules\asset-repository-ear\target\tmpEarDeps
BUILD SUCCESSFUL
The generated EAR file does not contain the ejb-client jar.
With Maven 1.1 beta 1, it fails because it cannot find the ejb-client file in the repository:
[fvr@tcosl016 asset-repository-ear]$ /cygdrive/c/MyApps/maven-1.1-beta-1/bin/maven ear
__ __
| \/ |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
|_| |_\__,_|\_/\___|_||_| v. 1.1-beta-1
Forsøker å laste ned asset-repository-ejb-1.0-SNAPSHOT.jar.
Artifact /sintef/ejbs/asset-repository-ejb-1.0-SNAPSHOT.jar doesn't exist in remote repository, but it exists locally.
Forsøker å laste ned asset-repository-ejb-1.0-SNAPSHOT.ejb-client.
ADVARSEL: Mislykket nedlasting av asset-repository-ejb-1.0-SNAPSHOT.ejb-client.
Byggeprosessen kan ikke fortsette på grunn av følgende mislykkede avhengighet:
asset-repository-ejb-1.0-SNAPSHOT.ejb-client
> EJBArtifactTypeHandler should append "-client" to artifactId, not version string?
> ---------------------------------------------------------------------------------
>
> Key: MPEJB-19
> URL: http://jira.codehaus.org/browse/MPEJB-19
> Project: maven-ejb-plugin
> Type: Bug
> Versions: 1.7
> Environment: Maven 1.0.2, maven-ejb-plugin 1.7-SNAPSHOT
> Reporter: Fredrik Vraalsen
> Assignee: Brett Porter
> Attachments: ejb-client-name-testcase.patch, ejb-client-name.patch
>
>
> I just checked out the latest version of the maven-ejb-plugin which installs ejb-client jars with a different name. Thanks for the good work!
> However, I'm wondering why the ejb-client jar appends "-client" to the version string rather than the artifactId, which seems more appropriate to me at least? The attached patch changes this.
> Cheers,
> Fredrik
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org