[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29874: [SPARK-32998][BUILD] Add ability to override default remote repos with internal one

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29874:
URL: https://github.com/apache/spark/pull/29874#discussion_r510481629



##########
File path: build/sbt-launch-lib.bash
##########
@@ -39,7 +39,13 @@ dlog () {
 
 acquire_sbt_jar () {
   SBT_VERSION=`awk -F "=" '/sbt\.version/ {print $2}' ./project/build.properties`
-  URL1=https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/${SBT_VERSION}/sbt-launch-${SBT_VERSION}.jar
+  #
+  # TYPESAFE_MIRROR and DEFAULT_ARTIFACT_REPOSITORY env variables can be used to only fetch
+  # artifacts from internal repos only.
+  # Ex:
+  #   TYPESAFE_MIRROR=https://artifacts.internal.com/lightbend-dist

Review comment:
       `TYPESAFE_MIRROR` is only used at `build/mvn`
   ```
   $ git grep TYPESAFE_MIRROR
   build/mvn:    local TYPESAFE_MIRROR=${TYPESAFE_MIRROR:-https://downloads.lightbend.com}
   build/mvn:      "${TYPESAFE_MIRROR}/zinc/${ZINC_VERSION}" \
   build/mvn:  local TYPESAFE_MIRROR=${TYPESAFE_MIRROR:-https://downloads.lightbend.com}
   build/mvn:    "${TYPESAFE_MIRROR}/scala/${scala_version}" \
   ```
   
   Shall we skip to mention it here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org