You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2021/10/11 09:57:27 UTC
[GitHub] [poi] thoniTUB opened a new pull request #261: Correct Maximum Width Calculation of unmerged Cells
thoniTUB opened a new pull request #261:
URL: https://github.com/apache/poi/pull/261
I strumbled upon this code line, it did't cause a problem for me. However it could cause a problem if at some point merged cells are used, but the unmerge width is requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #261: Correct Maximum Width Calculation of unmerged Cells
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #261:
URL: https://github.com/apache/poi/pull/261#issuecomment-939937990
I'll probably need to revert this as it breaks a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #261: Correct Maximum Width Calculation of unmerged Cells
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #261:
URL: https://github.com/apache/poi/pull/261#issuecomment-939987717
I modified the assertion on the test. Will still need to look into this more to see if this change is actually right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] thoniTUB commented on pull request #261: Correct Maximum Width Calculation of unmerged Cells
Posted by GitBox <gi...@apache.org>.
thoniTUB commented on pull request #261:
URL: https://github.com/apache/poi/pull/261#issuecomment-939918434
Alright, your welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] asfgit closed pull request #261: Correct Maximum Width Calculation of unmerged Cells
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #261:
URL: https://github.com/apache/poi/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #261: Correct Maximum Width Calculation of unmerged Cells
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #261:
URL: https://github.com/apache/poi/pull/261#issuecomment-939898787
Thanks - this is merged - will see about test coverage later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org