You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/01/27 23:07:43 UTC
[jira] Created: (HADOOP-7122) Timed out shell commands leak Timer
threads
Timed out shell commands leak Timer threads
-------------------------------------------
Key: HADOOP-7122
URL: https://issues.apache.org/jira/browse/HADOOP-7122
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Critical
Fix For: 0.22.0
When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987831#action_12987831 ]
Hadoop QA commented on HADOOP-7122:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12469608/hadoop-7122.txt
against trunk revision 1063613.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//console
This message is automatically generated.
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7122:
--------------------------------
Status: Patch Available (was: Open)
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988012#action_12988012 ]
Hudson commented on HADOOP-7122:
--------------------------------
Integrated in Hadoop-Common-22-branch #20 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/20/])
HADOOP-7122. Fix thread leak when shell commands time out. Contributed by Todd Lipcon
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7122:
--------------------------------
Attachment: hadoop-7122.txt
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7122:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk and branch, thanks for the quick review.
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987802#action_12987802 ]
Hadoop QA commented on HADOOP-7122:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12469606/hadoop-7122.txt
against trunk revision 1063613.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//console
This message is automatically generated.
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989126#comment-12989126 ]
Hudson commented on HADOOP-7122:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #492 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/])
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987819#action_12987819 ]
Eli Collins commented on HADOOP-7122:
-------------------------------------
Good catch.
+1
Nits:
- The System.err.println on line 111 in the test seems gratuitous
- On line 112 perhaps s/contains/equals/ since you're explicitly looking for the Timer objects
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988034#action_12988034 ]
Hudson commented on HADOOP-7122:
--------------------------------
Integrated in Hadoop-Common-trunk #589 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/589/])
HADOOP-7122. Fix thread leak when shell commands time out. Contributed by Todd Lipcon
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987822#action_12987822 ]
Eli Collins commented on HADOOP-7122:
-------------------------------------
Makes sense.
+1
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987820#action_12987820 ]
Todd Lipcon commented on HADOOP-7122:
-------------------------------------
Unfortuntaely the Timer threads have java.util.TimerThread on the stack, but this class is a private "implementation detail" class. To work across different JVMs I elected to just look for the word "Timer" - make sense?
Will fix the println
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt, hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7122) Timed out shell commands leak Timer
threads
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7122:
--------------------------------
Attachment: hadoop-7122.txt
> Timed out shell commands leak Timer threads
> -------------------------------------------
>
> Key: HADOOP-7122
> URL: https://issues.apache.org/jira/browse/HADOOP-7122
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is leaked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.