You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (JIRA)" <ji...@apache.org> on 2012/06/12 22:43:42 UTC
[jira] [Created] (SANDBOX-419) [BeanUtils2] Implement
setIndexed(String propertyName) on DefaultBeanAccessor
Benedikt Ritter created SANDBOX-419:
---------------------------------------
Summary: [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
Key: SANDBOX-419
URL: https://issues.apache.org/jira/browse/SANDBOX-419
Project: Commons Sandbox
Issue Type: Improvement
Components: BeanUtils2
Affects Versions: Nightly Builds
Reporter: Benedikt Ritter
Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-419) [BeanUtils2] Implement
setIndexed(String propertyName) on DefaultBeanAccessor
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420591#comment-13420591 ]
Simone Tripodi commented on SANDBOX-419:
----------------------------------------
I applied the patch - wich is quiet good - see revision 1364590 - and let it open to address some TODOs.
{quote}
can we be sure that the first parameter type always will be of type int and the second parameter type will be the type of the indexed property?
{quote}
uhm don't think so...
{quote}
if so do we have to check if the first parameter is really of type int or do we only have to check if the second parameter type is assignment compatible to value?
{quote}
that would be better option, IMHO
Few minor observations about applied patch:
* {{IndexedPropertySetter}} was good but thought {{DefaultIndexedPropertySetter}} would be more canonical according to interfaces/implementations "conventions" we adopted;
* {{o.a.c.bu2.internal}} package doesn't exist anymore, I adapted the code - maybe your local copy was not properly up-to-date;
* trivial code format - no worries, already fixed.
Looking forward the next patch to mark this issue as _resolved_
TIA!
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
> Key: SANDBOX-419
> URL: https://issues.apache.org/jira/browse/SANDBOX-419
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANDBOX-419) [BeanUtils2] Implement
setIndexed(String propertyName) on DefaultBeanAccessor
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi updated SANDBOX-419:
-----------------------------------
Assignee: Simone Tripodi
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
> Key: SANDBOX-419
> URL: https://issues.apache.org/jira/browse/SANDBOX-419
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-419) [BeanUtils2] Implement
setIndexed(String propertyName) on DefaultBeanAccessor
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420906#comment-13420906 ]
Simone Tripodi commented on SANDBOX-419:
----------------------------------------
no rush Bene - this issue can be closed later, no need to have it closed before applying other patches.
Thanks! :)
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
> Key: SANDBOX-419
> URL: https://issues.apache.org/jira/browse/SANDBOX-419
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANDBOX-419) [BeanUtils2] Implement
setIndexed(String propertyName) on DefaultBeanAccessor
Posted by "Benedikt Ritter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated SANDBOX-419:
------------------------------------
Attachment: SANDBOX-419.patch
I've created a patch for this issue. Summary:
* Changed {{DefaultIndexedPropertySetter}} to implement {{IndexedPropertySetterAccessor}} (rather than {{IndexedPropertyGetterAccessor}})
* Created a new implementation of {{BeanPropertySetter}} for indexed porperties.
However this patch only servers for the purpose of discussion, since I'm unsure about two issues:
# name of the new {{BeanPropertySetter}} implementation: Maybe it should be changed to "IndexedBeanPropertySetter" to make it clear that it is variant of DefaultBeanPropertySetter
# checking of parameter types of the indexed setter method in {{IndexedPropertySetter}}:
#* can we be sure that the first parameter type always will be of type int and the second parameter type will be the type of the indexed property?
#* if so do we have to check if the first parameter is really of type int or do we only have to check if the second parameter type is assignment compatible to value?
After we have agreed on this points I can create a new patch (or you can simply modify the patch).
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
> Key: SANDBOX-419
> URL: https://issues.apache.org/jira/browse/SANDBOX-419
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-419) [BeanUtils2] Implement
setIndexed(String propertyName) on DefaultBeanAccessor
Posted by "Benedikt Ritter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420878#comment-13420878 ]
Benedikt Ritter commented on SANDBOX-419:
-----------------------------------------
Hey Simo,
thanks for reviewing and for your comments. Right now I can't fix the TODOs you mentioned, because my hole working copy contains changes from SANDBOX-423. I will have to finish work on that issue and wait for you to commit it, before I can create a working patch for this one.
I guess it's about time for me to start using git-svn... :)
Regards,
Benedikt
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
> Key: SANDBOX-419
> URL: https://issues.apache.org/jira/browse/SANDBOX-419
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira