[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8200: ARROW-8883: [Rust] [Integration] Enable more tests

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #8200:
URL: https://github.com/apache/arrow/pull/8200#discussion_r512922566



##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -609,10 +628,45 @@ pub(crate) fn get_fb_field_type<'a: 'b, 'b>(
                 children: Some(fbb.create_vector(&children[..])),
             }
         }
+        Dictionary(_, value_type) => {
+            // In this library, the dictionary "type" is a logical construct. Here we
+            // pass through to the value type, as we've already captured the index
+            // type in the DictionaryEncoding metadata in the parent field

Review comment:
       I also struggled with this a bit in the c-data interface.

##########
File path: rust/arrow/src/util/integration_util.rs
##########
@@ -97,12 +144,43 @@ impl ArrowJsonSchema {
         for i in 0..field_len {
             let json_field = &self.fields[i];
             let field = schema.field(i);
-            assert_eq!(json_field, &field.to_json());
+            if !json_field.equals_field(field) {
+                return false;
+            }
         }
         true
     }
 }
 
+impl ArrowJsonField {
+    /// Compare the Arrow JSON field with the Arrow `Field`
+    fn equals_field(&self, field: &Field) -> bool {
+        dbg!((&self, &field));

Review comment:
       dbg

##########
File path: rust/arrow/src/array/data.rs
##########
@@ -209,6 +209,61 @@ impl ArrayData {
     }
 }
 
+impl PartialEq for ArrayData {
+    fn eq(&self, other: &Self) -> bool {
+        assert_eq!(

Review comment:
       does't `assert_eq!` panic?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org