[GitHub] [superset] junlincc commented on a change in pull request #12411: feat: Resizable dataset and controls panels on Explore view

[GitBox <gi...@apache.org>]

junlincc commented on a change in pull request #12411:
URL: https://github.com/apache/superset/pull/12411#discussion_r555308316



##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -452,7 +455,13 @@ function ExploreViewContainer(props) {
           <Icon name="dataset-physical" width={16} />
         </div>
       ) : null}
-      <div className="col-sm-3 explore-column controls-column">
+      <Resizable
+        defaultSize={{ width: 320 }}
+        minWidth={320}
+        maxWidth="33%"

Review comment:
       33% is already squeezing the viz. we tested 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org