[GitHub] eolivelli commented on a change in pull request #1392: [table service] a zk based storage container controller

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1392: [table service] a zk based storage container controller 
URL: https://github.com/apache/bookkeeper/pull/1392#discussion_r186125981
 
 

 ##########
 File path: stream/server/src/main/java/org/apache/bookkeeper/stream/cluster/StreamCluster.java
 ##########
 @@ -74,17 +77,10 @@ public static StreamCluster build(StreamClusterSpec spec) {
         return new StreamCluster(spec);
     }
 
-    //
-    // DL Settings
-    //
-    private static final String ROOT_PATH = "/stream";
-    private static final String LEDGERS_PATH = "/stream/ledgers";
-    private static final String LEDGERS_AVAILABLE_PATH = "/stream/ledgers/available";
-    private static final String NAMESPACE = "/stream/storage";
-
-    private static ServerConfiguration newServerConfiguration(String zkEnsemble) {
+    private static ServerConfiguration newBookieConfiguration(String zkEnsemble) {
         ServerConfiguration serverConf = new ServerConfiguration();
-        serverConf.setMetadataServiceUri("zk://" + zkEnsemble + LEDGERS_PATH);
+        serverConf.setMetadataServiceUri(
+            "zk://" + zkEnsemble + getSegmentsRootPath(StorageConstants.ZK_METADATA_ROOT_PATH));
 
 Review comment:
   If the client can be in the same process of the bookie consider adding netty *local* endpoint to bookie config

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services