[GitHub] [incubator-teaclave] bigdata-memory commented on a change in pull request #610: fix link scripts

[GitBox <gi...@apache.org>]

bigdata-memory commented on a change in pull request #610:
URL: https://github.com/apache/incubator-teaclave/pull/610#discussion_r799727505



##########
File path: cmake/scripts/sgx_link_sign.sh
##########
@@ -44,10 +44,25 @@ if [ ! "$LIBENCLAVE_PATH" -nt "$SIGNED_PATH" ] \
     exit 0
 fi
 
-TEACLAVE_LINK_FLAGS="-L${TEACLAVE_OUT_DIR} -lpycomponent ffi.o -lpypy-c -lsgx_tlibc_ext -lffi"
-if [ "$TEACLAVE_EXECUTOR_WAMR" == "ON" ]; then
-    TEACLAVE_LINK_FLAGS+=" -lvmlib"
-fi
+TEACLAVE_LINK_FLAGS="-L${TEACLAVE_OUT_DIR}"
+
+case $CUR_PKG_NAME in
+
+  teaclave_access_control_service_enclave | teaclave_functional_tests_enclave )
+    TEACLAVE_LINK_FLAGS+=" -lpycomponent ffi.o -lpypy-c -lsgx_tlibc_ext -lffi"
+    ;;
+
+  teaclave_execution_service_enclave | teaclave_unit_tests_enclave |  teaclave_integration_tests_enclave)
+    TEACLAVE_LINK_FLAGS+=" -lpycomponent ffi.o -lpypy-c -lsgx_tlibc_ext -lffi"
+    if [ "$TEACLAVE_EXECUTOR_WAMR" == "ON" ]; then
+        TEACLAVE_LINK_FLAGS+=" -lvmlib"
+    fi
+    ;;
+
+  *)
+    ;;

Review comment:
       may consider adding something in default branch to cover unexpected case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org