[jira] [Resolved] (STORM-486) Call ring.adapter.jetty/run-jetty adds a second handler to server

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans resolved STORM-486.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: feature-security

Thanks Derek,

I pulled this into the security branch.

> Call ring.adapter.jetty/run-jetty adds a second handler to server
> -----------------------------------------------------------------
>
>                 Key: STORM-486
>                 URL: https://issues.apache.org/jira/browse/STORM-486
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Derek Dagit
>            Assignee: Derek Dagit
>              Labels: security
>             Fix For: feature-security
>
>
> We use a "configurator" to configure jetty servers with one or more filters based on storm configuration and based on which daemon is being configured.
> One use case is that the logviewer must both compress responses and authenticate incoming requests via a custom filter.
> [Code|https://github.com/apache/incubator-storm/blob/b19fdbb7444e9d3ea38ede9d186055319df4751d/storm-core/src/clj/backtype/storm/ui/helpers.clj#L168-L181]
> When more than one filter is used, the configurator adds the configured handler once, but then ring.adapter.jetty/run-jetty adds another handler.  Having two handlers causes trouble with the server. One handler constructs the response, and when the second handler tries to do the same, it finds the output stream is closed.
> Most of the time this results in extra log messages and incorrect page loads, but with HTTP DRPC calls, it can potentially cause the wrong result to be returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)