You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/03 11:27:27 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2296: LUCENE-9728: Hunspell: add a performance test
donnerpeter opened a new pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
We need some way check that changes don't regress performance, and preferably improve it
# Solution
See below
# Tests
Added a `TestPerformance` which prints some times that can be compared before and after risky changes. It's not run on CI yet and never fails.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773883740
Should this be rebased? Seems to contain unrelated changes not just the test file. A JMH test would probably strip some of the boilerplate but don't know if it's worth pulling in additional dependencies and infrastructure - perhaps not. A wall time estimate is fine at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773887234
`Dictionary` changes are intended, because the test parses the corpus based on the affix file `WORDCHARS` directive, which is parsed together with the other directives in `Dictionary`.
JMH would indeed get rid of manual warmup and iteration, but complicate everything. And this isn't exactly a microbenchmark, so I too think the current approach is fine for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773883740
Should this be rebased? Seems to contain unrelated changes not just the test file. A JMH test would probably strip some of the boilerplate but don't know if it's worth pulling in additional dependencies and infrastructure - perhaps not. A wall time estimate is fine at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2296: LUCENE-9728: Hunspell: add a performance test
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2296: LUCENE-9728: Hunspell: add a performance test
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773887234
`Dictionary` changes are intended, because the test parses the corpus based on the affix file `WORDCHARS` directive, which is parsed together with the other directives in `Dictionary`.
JMH would indeed get rid of manual warmup and iteration, but complicate everything. And this isn't exactly a microbenchmark, so I too think the current approach is fine for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org