You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by johanwitters <gi...@git.apache.org> on 2016/01/05 17:15:07 UTC
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
GitHub user johanwitters opened a pull request:
https://github.com/apache/storm/pull/989
AvroGenericRecordBolt instead of SequenceFileBolt
Changing the **example code** and use **AvroGenericRecordBolt** instead of
**SequenceFileBolt**…
Section “Support for Avro Files” starts by explained the use of org.apache.storm.hdfs.bolt.AvroGenericRecordBolt for Avro files.
However, the example code uses SequenceFileBolt instead, and that
doesn’t work, obviously because the method withSchemaAsString isn’t
part of SequenceFileBolt, but part of
org.apache.storm.hdfs.bolt.AvroGenericRecordBolt instead. So, the
change is nothing but changing the name of class SequenceFileBolt and
replace it with the correct AvroGenericRecordBolt.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johanwitters/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 51746991079dee7ac4ad4045eb3cfbadc78fc038
Author: johanwitters <jo...@witters.be>
Date: 2016-01-05T16:16:04Z
AvroGenericRecordBolt instead of SequenceFileBolt
Changing the example code and use AvroGenericRecordBolt instead of
SequenceFileBolt…
Section “Support for Avro Files” starts by explained the use of
org.apache.storm.hdfs.bolt.AvroGenericRecordBolt for Avro files.
However, the example code uses SequenceFileBolt instead, and that
doesn’t work, obviously because the method withSchemaAsString isn’t
part of SequenceFileBolt, but part of
org.apache.storm.hdfs.bolt.AvroGenericRecordBolt instead. So, the
change is nothing but changing the name of class SequenceFileBolt and
replace it with the correct AvroGenericRecordBolt.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/989#issuecomment-169050930
I would be +1 on this change if the PR were reopened. Thank you for catching my sloppy error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/989#issuecomment-169067783
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by johanwitters <gi...@git.apache.org>.
Github user johanwitters closed the pull request at:
https://github.com/apache/storm/pull/989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by johanwitters <gi...@git.apache.org>.
GitHub user johanwitters reopened a pull request:
https://github.com/apache/storm/pull/989
AvroGenericRecordBolt instead of SequenceFileBolt
Changing the **example code** and use **AvroGenericRecordBolt** instead of
**SequenceFileBolt**…
Section “Support for Avro Files” starts by explained the use of org.apache.storm.hdfs.bolt.AvroGenericRecordBolt for Avro files.
However, the example code uses SequenceFileBolt instead, and that
doesn’t work, obviously because the method withSchemaAsString isn’t
part of SequenceFileBolt, but part of
org.apache.storm.hdfs.bolt.AvroGenericRecordBolt instead. So, the
change is nothing but changing the name of class SequenceFileBolt and
replace it with the correct AvroGenericRecordBolt.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johanwitters/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 51746991079dee7ac4ad4045eb3cfbadc78fc038
Author: johanwitters <jo...@witters.be>
Date: 2016-01-05T16:16:04Z
AvroGenericRecordBolt instead of SequenceFileBolt
Changing the example code and use AvroGenericRecordBolt instead of
SequenceFileBolt…
Section “Support for Avro Files” starts by explained the use of
org.apache.storm.hdfs.bolt.AvroGenericRecordBolt for Avro files.
However, the example code uses SequenceFileBolt instead, and that
doesn’t work, obviously because the method withSchemaAsString isn’t
part of SequenceFileBolt, but part of
org.apache.storm.hdfs.bolt.AvroGenericRecordBolt instead. So, the
change is nothing but changing the name of class SequenceFileBolt and
replace it with the correct AvroGenericRecordBolt.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by johanwitters <gi...@git.apache.org>.
Github user johanwitters commented on the pull request:
https://github.com/apache/storm/pull/989#issuecomment-169058074
Always happy to receive +1s :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: AvroGenericRecordBolt instead of SequenceFileB...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/989#issuecomment-169068006
Since this is a comment change, we don't need to wait the full 24 hours to pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---