You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 11:25:01 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38658: [SPARK-41109][CORE][FOLLOWUP] Fix error class order
LuciferYang opened a new pull request, #38658:
URL: https://github.com/apache/spark/pull/38658
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1314066195
Thanks @MaxGekk @cloud-fan @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1313545319
Thanks for the fix this.
Do you know why this suddenly start failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1313667810
> Thanks for the fix this.
>
> Do you know why this suddenly start failing?
@itholic
After https://github.com/apache/spark/pull/38615 merging, there is a code style issue, which is fixed by https://github.com/apache/spark/pull/38645.
However, the merging of https://github.com/apache/spark/pull/38645 and https://github.com/apache/spark/pull/38626 is not determined to have `core` module changes.
Therefore, the testing of `core` module is not triggered after code merging into the master and no`SparkThrowableSuite` test failure is triggered.
The evidence is that I found the following log in the latest `Run tests` log,
```
2022-11-14T08:09:17.9465991Z [info] Found the following changed modules: repl, avro, examples
```
and only tested `repl`, `avro` this time.
https://pipelines.actions.githubusercontent.com/serviceHosts/03398d36-4378-4d47-a936-fba0a5e8ccb9/_apis/pipelines/1/runs/195451/signedlogcontent/16?urlExpires=2022-11-14T13%3A04%3A29.9673237Z&urlSigningMethod=HMACV1&urlSignature=LG43JDLy%2B3THPnt81QbCb3qSfW9kus%2FIT1QXEPzwYm4%3D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1313699403
friendly ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1314019272
+1, LGTM. Merging to master. I have checked the test suite locally:
```
[info] SparkThrowableSuite:
...
[info] - prohibit dots in error class names (87 milliseconds)
[info] Run completed in 2 seconds, 823 milliseconds.
[info] Total number of tests run: 15
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 15, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Fix error class order
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1313537233
cc @MaxGekk @dongjoon-hyun
for fix GA Task:
https://github.com/LuciferYang/spark/actions/runs/3459895559/jobs/5775820010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
URL: https://github.com/apache/spark/pull/38658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1313551135
Still under investigation. It should have been discovered very early
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38658: [SPARK-41109][CORE][FOLLOWUP] Re-order error class to fix `SparkThrowableSuite`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38658:
URL: https://github.com/apache/spark/pull/38658#issuecomment-1313618482
An interesting thing. I didn't find logs related to `SparkThrowableSuite` tests in the two tests passed link. Is that my problem?
https://github.com/apache/spark/actions/runs/3459197617/jobs/5774348420
https://pipelines.actions.githubusercontent.com/serviceHosts/03398d36-4378-4d47-a936-fba0a5e8ccb9/_apis/pipelines/1/runs/195427/signedlogcontent/16?urlExpires=2022-11-14T12%3A27%3A26.4982268Z&urlSigningMethod=HMACV1&urlSignature=AOd65uKRiefjdnz%2FerE8GKR9pY8ZFrzkH%2BUfJpqtMrI%3D
https://github.com/apache/spark/actions/runs/3459583062/jobs/5778362944
https://pipelines.actions.githubusercontent.com/serviceHosts/03398d36-4378-4d47-a936-fba0a5e8ccb9/_apis/pipelines/1/runs/195451/signedlogcontent/16?urlExpires=2022-11-14T12%3A29%3A39.1035990Z&urlSigningMethod=HMACV1&urlSignature=NcfcQTvfLAL5tHLDUDNlOjxO40tSZ0VdGb5RZPOkCtQ%3D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org