You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/03/22 16:44:55 UTC

Review Request 57847: Ambari-server CLI to setup Database Options Broken

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57847/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20532
    https://issues.apache.org/jira/browse/AMBARI-20532


Repository: ambari


Description
-------

When trying to automate the configuration of Ambari through the 'ambari-server setup' with options to setup the database and JDK, the return claims success but fails to make adjustments to 'ambari.properties' and 'password.dat' files.
Example CLI Call:
/usr/sbin/ambari-server setup --java-home=/usr/java/default --database=mysql --databasehost="db.hdp.local" --databaseport=3306 --databasename=ambari --databaseusername=ambari --databasepassword=hortonworks --jdbc-driver=/usr/share/java/mysql-connector-java.jar --jdbc-db=mysql --master-key=hortonworks --master-key-persist=true --truststore-type=jceks --truststore-path=/etc/ambari-server/conf/password.jceks --truststore-password=hortonworks -v -g


Diffs
-----

  ambari-server/src/main/python/ambari-server.py c985d65 


Diff: https://reviews.apache.org/r/57847/diff/1/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57847/#review169735
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On March 22, 2017, 4:44 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57847/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 4:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20532
>     https://issues.apache.org/jira/browse/AMBARI-20532
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When trying to automate the configuration of Ambari through the 'ambari-server setup' with options to setup the database and JDK, the return claims success but fails to make adjustments to 'ambari.properties' and 'password.dat' files.
> Example CLI Call:
> /usr/sbin/ambari-server setup --java-home=/usr/java/default --database=mysql --databasehost="db.hdp.local" --databaseport=3306 --databasename=ambari --databaseusername=ambari --databasepassword=hortonworks --jdbc-driver=/usr/share/java/mysql-connector-java.jar --jdbc-db=mysql --master-key=hortonworks --master-key-persist=true --truststore-type=jceks --truststore-path=/etc/ambari-server/conf/password.jceks --truststore-password=hortonworks -v -g
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py c985d65 
> 
> 
> Diff: https://reviews.apache.org/r/57847/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57847/#review170322
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On March 28, 2017, 1:08 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57847/
> -----------------------------------------------------------
> 
> (Updated March 28, 2017, 1:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20532
>     https://issues.apache.org/jira/browse/AMBARI-20532
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When trying to automate the configuration of Ambari through the 'ambari-server setup' with options to setup the database and JDK, the return claims success but fails to make adjustments to 'ambari.properties' and 'password.dat' files.
> Example CLI Call:
> /usr/sbin/ambari-server setup --java-home=/usr/java/default --database=mysql --databasehost="db.hdp.local" --databaseport=3306 --databasename=ambari --databaseusername=ambari --databasepassword=hortonworks --jdbc-driver=/usr/share/java/mysql-connector-java.jar --jdbc-db=mysql --master-key=hortonworks --master-key-persist=true --truststore-type=jceks --truststore-path=/etc/ambari-server/conf/password.jceks --truststore-password=hortonworks -v -g
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py c985d65 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 04b96f5 
>   ambari-server/src/test/python/TestAmbariServer.py 9579c22 
> 
> 
> Diff: https://reviews.apache.org/r/57847/diff/2/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57847/
-----------------------------------------------------------

(Updated \u041c\u0430\u0440\u0442 28, 2017, 1:08 \u043f.\u043f.)


Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20532
    https://issues.apache.org/jira/browse/AMBARI-20532


Repository: ambari


Description
-------

When trying to automate the configuration of Ambari through the 'ambari-server setup' with options to setup the database and JDK, the return claims success but fails to make adjustments to 'ambari.properties' and 'password.dat' files.
Example CLI Call:
/usr/sbin/ambari-server setup --java-home=/usr/java/default --database=mysql --databasehost="db.hdp.local" --databaseport=3306 --databasename=ambari --databaseusername=ambari --databasepassword=hortonworks --jdbc-driver=/usr/share/java/mysql-connector-java.jar --jdbc-db=mysql --master-key=hortonworks --master-key-persist=true --truststore-type=jceks --truststore-path=/etc/ambari-server/conf/password.jceks --truststore-password=hortonworks -v -g


Diffs (updated)
-----

  ambari-server/src/main/python/ambari-server.py c985d65 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 04b96f5 
  ambari-server/src/test/python/TestAmbariServer.py 9579c22 


Diff: https://reviews.apache.org/r/57847/diff/2/

Changes: https://reviews.apache.org/r/57847/diff/1-2/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen