[GitHub] [lucene] rmuir commented on a change in pull request #134: LUCENE-9935: Enable bulk merge for stored fields with index sort

[GitBox <gi...@apache.org>]

rmuir commented on a change in pull request #134:
URL: https://github.com/apache/lucene/pull/134#discussion_r630522095



##########
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java
##########
@@ -76,7 +75,8 @@
   static final int TYPE_MASK = (int) PackedInts.maxValue(TYPE_BITS);
 
   static final int VERSION_START = 1;
-  static final int VERSION_CURRENT = VERSION_START;
+  static final int VERSION_TRACK_DIRTY_CHUNK = 2;
+  static final int VERSION_CURRENT = VERSION_TRACK_DIRTY_CHUNK;

Review comment:
       because lucene 9.0 is not yet released, we shouldn't bump any internal versions as we don't need backwards compatibility with them here. can remove this part and other conditionals related to it elsewhere.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org