You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/23 18:26:30 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13749: fix: Disallows negative options remaining in SelectControl
michael-s-molina opened a new pull request #13749:
URL: https://github.com/apache/superset/pull/13749
### SUMMARY
Disallows negative options remaining in `SelectControl`. When a `SelectControl` has no options available, the user can still enter values and this caused the assistive text to contain negative values.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="193" alt="Screen Shot 2021-03-23 at 3 19 33 PM" src="https://user-images.githubusercontent.com/70410625/112198003-71567900-8beb-11eb-9f20-c03d1ddf31b6.png">
<img width="194" alt="Screen Shot 2021-03-23 at 3 20 14 PM" src="https://user-images.githubusercontent.com/70410625/112198006-7287a600-8beb-11eb-8f40-486b5a59073a.png">
### TEST PLAN
1 - Find a `SelectControl` with no options available (polygon chart -> customize for example).
2 - Enter arbitrary text as a value.
3 - No assistive text should be displayed.
@rusackas @junlincc
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (6ef0a05) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **increase** coverage by `0.23%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 6ef0a05 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
+ Coverage 77.23% 77.47% +0.23%
==========================================
Files 933 933
Lines 47383 47186 -197
Branches 5928 5860 -68
==========================================
- Hits 36597 36555 -42
+ Misses 10638 10489 -149
+ Partials 148 142 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.23% <100.00%> (ø)` | |
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+9.85%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <0.00%> (+17.59%)` | :arrow_up: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <0.00%> (+24.48%)` | :arrow_up: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <0.00%> (+60.00%)` | :arrow_up: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `100.00% <0.00%> (+62.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (5d06485) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **decrease** coverage by `0.84%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 5d06485 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
- Coverage 77.23% 76.39% -0.85%
==========================================
Files 933 933
Lines 47383 47185 -198
Branches 5928 5873 -55
==========================================
- Hits 36597 36047 -550
- Misses 10638 10980 +342
- Partials 148 158 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.91% <100.00%> (-1.33%)` | :arrow_down: |
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `89.28% <100.00%> (-4.47%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (5d06485) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **increase** coverage by `0.16%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 5d06485 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
+ Coverage 77.23% 77.39% +0.16%
==========================================
Files 933 933
Lines 47383 47186 -197
Branches 5928 5873 -55
==========================================
- Hits 36597 36521 -76
+ Misses 10638 10523 -115
+ Partials 148 142 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+9.85%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <0.00%> (+17.59%)` | :arrow_up: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <0.00%> (+24.48%)` | :arrow_up: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <0.00%> (+60.00%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (6ef0a05) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **decrease** coverage by `1.32%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 6ef0a05 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
- Coverage 77.23% 75.91% -1.33%
==========================================
Files 933 933
Lines 47383 47185 -198
Branches 5928 5860 -68
==========================================
- Hits 36597 35821 -776
- Misses 10638 11191 +553
- Partials 148 173 +25
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| ... and [96 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (5d06485) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 5d06485 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
+ Coverage 77.23% 77.40% +0.17%
==========================================
Files 933 933
Lines 47383 47186 -197
Branches 5928 5873 -55
==========================================
- Hits 36597 36526 -71
+ Misses 10638 10518 -120
+ Partials 148 142 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.27% <100.00%> (+0.03%)` | :arrow_up: |
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `89.47% <0.00%> (+4.21%)` | :arrow_up: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+9.85%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <0.00%> (+17.59%)` | :arrow_up: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <0.00%> (+24.48%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (6ef0a05) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **decrease** coverage by `0.72%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 6ef0a05 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
- Coverage 77.23% 76.50% -0.73%
==========================================
Files 933 933
Lines 47383 47185 -198
Branches 5928 5860 -68
==========================================
- Hits 36597 36101 -496
- Misses 10638 10927 +289
- Partials 148 157 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.70% <100.00%> (-5.54%)` | :arrow_down: |
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [58 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #13749:
URL: https://github.com/apache/superset/pull/13749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (5d06485) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 5d06485 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
+ Coverage 77.23% 77.40% +0.17%
==========================================
Files 933 933
Lines 47383 47186 -197
Branches 5928 5873 -55
==========================================
- Hits 36597 36526 -71
+ Misses 10638 10518 -120
+ Partials 148 142 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.27% <100.00%> (+0.03%)` | :arrow_up: |
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `89.47% <0.00%> (+4.21%)` | :arrow_up: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+9.85%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <0.00%> (+17.59%)` | :arrow_up: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <0.00%> (+24.48%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-808669335
LGTM! Thanks for the enhancement
@ktmud can you help merge, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #13749:
URL: https://github.com/apache/superset/pull/13749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13749: fix: Disallows negative options remaining in SelectControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13749:
URL: https://github.com/apache/superset/pull/13749#issuecomment-805168425
# [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=h1) Report
> Merging [#13749](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=desc) (5d06485) into [master](https://codecov.io/gh/apache/superset/commit/452b53092b227984a03ee3460fd2ecd86e18d0aa?el=desc) (452b530) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 5d06485 differs from pull request most recent head 2ee3433. Consider uploading reports for the commit 2ee3433 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13749 +/- ##
==========================================
+ Coverage 77.23% 77.40% +0.17%
==========================================
Files 933 933
Lines 47383 47186 -197
Branches 5928 5873 -55
==========================================
- Hits 36597 36526 -71
+ Misses 10638 10518 -120
+ Partials 148 142 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.26% <100.00%> (+0.02%)` | :arrow_up: |
| javascript | `63.53% <100.00%> (+0.06%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `89.47% <0.00%> (+4.21%)` | :arrow_up: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+9.85%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <0.00%> (+17.59%)` | :arrow_up: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <0.00%> (+24.48%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/13749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=footer). Last update [452b530...2ee3433](https://codecov.io/gh/apache/superset/pull/13749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org