You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/11/02 19:53:33 UTC
[kudu-CR] fix MiniKdc lsof usage on Ubuntu 16.04
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4919
to review the following change.
Change subject: fix MiniKdc lsof usage on Ubuntu 16.04
......................................................................
fix MiniKdc lsof usage on Ubuntu 16.04
Another instance of the bug fixed by commit 57ccc9a (though it was actually
version 4.88 of lsof that made the change, not 4.89; see the changelog [1]
for more details).
1. ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/ChangeLog
Change-Id: I0e49dd8d6b6c0ac05edeff327602b971ea8516db
---
M src/kudu/security/mini_kdc.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/4919/1
--
To view, visit http://gerrit.cloudera.org:8080/4919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e49dd8d6b6c0ac05edeff327602b971ea8516db
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fix MiniKdc lsof usage on Ubuntu 16.04
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: fix MiniKdc lsof usage on Ubuntu 16.04
......................................................................
fix MiniKdc lsof usage on Ubuntu 16.04
Another instance of the bug fixed by commit 57ccc9a (though it was actually
version 4.88 of lsof that made the change, not 4.89; see the changelog [1]
for more details).
1. ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/ChangeLog
Change-Id: I0e49dd8d6b6c0ac05edeff327602b971ea8516db
Reviewed-on: http://gerrit.cloudera.org:8080/4919
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/security/mini_kdc.cc
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e49dd8d6b6c0ac05edeff327602b971ea8516db
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fix MiniKdc lsof usage on Ubuntu 16.04
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: fix MiniKdc lsof usage on Ubuntu 16.04
......................................................................
Patch Set 1: Code-Review+2
Tested and works on OS X
--
To view, visit http://gerrit.cloudera.org:8080/4919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e49dd8d6b6c0ac05edeff327602b971ea8516db
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] fix MiniKdc lsof usage on Ubuntu 16.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: fix MiniKdc lsof usage on Ubuntu 16.04
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4919/1/src/kudu/security/mini_kdc.cc
File src/kudu/security/mini_kdc.cc:
PS1, Line 279: '-Ffn
Another option is to use '-Fn0' flag. Doing that makes lsof using '\0' as a field separator instead of '\n', so there will be 2 lines always. But the downside is that those lines contain multiple entities packed into the line.
--
To view, visit http://gerrit.cloudera.org:8080/4919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e49dd8d6b6c0ac05edeff327602b971ea8516db
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes