You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cd...@apache.org on 2008/06/19 20:49:29 UTC

svn commit: r669645 - in /hadoop/core/branches/branch-0.18: CHANGES.txt src/mapred/org/apache/hadoop/mapred/JobConf.java

Author: cdouglas
Date: Thu Jun 19 11:49:29 2008
New Revision: 669645

URL: http://svn.apache.org/viewvc?rev=669645&view=rev
Log:
HADOOP-3599. Fix JobConf::setCombineOnceOnly to modify the instance rather
than a parameter. Contributed by Owen O'Malley.

Modified:
    hadoop/core/branches/branch-0.18/CHANGES.txt
    hadoop/core/branches/branch-0.18/src/mapred/org/apache/hadoop/mapred/JobConf.java

Modified: hadoop/core/branches/branch-0.18/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/branches/branch-0.18/CHANGES.txt?rev=669645&r1=669644&r2=669645&view=diff
==============================================================================
--- hadoop/core/branches/branch-0.18/CHANGES.txt (original)
+++ hadoop/core/branches/branch-0.18/CHANGES.txt Thu Jun 19 11:49:29 2008
@@ -648,6 +648,9 @@
     HADOOP-3569. KFS input stream read() now correctly reads 1 byte
     instead of 4. (Sriram Rao via omalley)
 
+    HADOOP-3599. Fix JobConf::setCombineOnceOnly to modify the instance rather
+    than a parameter. (Owen O'Malley via cdouglas)
+
 Release 0.17.1 - Unreleased
 
   INCOMPATIBLE CHANGES

Modified: hadoop/core/branches/branch-0.18/src/mapred/org/apache/hadoop/mapred/JobConf.java
URL: http://svn.apache.org/viewvc/hadoop/core/branches/branch-0.18/src/mapred/org/apache/hadoop/mapred/JobConf.java?rev=669645&r1=669644&r2=669645&view=diff
==============================================================================
--- hadoop/core/branches/branch-0.18/src/mapred/org/apache/hadoop/mapred/JobConf.java (original)
+++ hadoop/core/branches/branch-0.18/src/mapred/org/apache/hadoop/mapred/JobConf.java Thu Jun 19 11:49:29 2008
@@ -803,8 +803,8 @@
    * the map. Otherwise, combiner may be run zero or more times.
    */
   @Deprecated
-  public void setCombineOnceOnly(JobConf conf, boolean value) {
-    conf.setBoolean("mapred.combine.once", value);
+  public void setCombineOnceOnly(boolean value) {
+    setBoolean("mapred.combine.once", value);
   }
 
   @Deprecated