[jira] [Resolved] (THRIFT-4129) C++ TNonblockingServer fd leak when failing to dispatch new connections

["James E. King, III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King, III resolved THRIFT-4129.
----------------------------------------
    Resolution: Fixed

Committed - thanks.

> C++ TNonblockingServer fd leak when failing to dispatch new connections
> -----------------------------------------------------------------------
>
>                 Key: THRIFT-4129
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4129
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3, 0.10.0
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> In THRIFT-2789 the error handling for connections where notify fails leaks a file descriptor.
> This was reported and fixed in a pull request without an Apache Jira entry:
> https://github.com/apache/thrift/pull/1210/files
> When failing to dispatch new connections to other IO threads other
> than the number 0, we returned these connections for reuse without
> closing them, so the corresponding fds were leaked forever.
> We should close these connections instead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)