You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/03/16 22:11:41 UTC
Review Request 44931: Use Version Definition value for
package-version when installing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44931/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-15447
https://issues.apache.org/jira/browse/AMBARI-15447
Repository: ambari
Description
-------
The version defintion file defines a package version that should be used when installing packages. The current calculation cannot be considered reliable, but should stay as a contingency for when NOT using a version definition.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py a8098a0
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 402a338
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e32e2f9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 07e62b3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1cd9c0a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 3398709
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 6bcedf5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java dea83a1
ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80
ambari-server/src/test/resources/hbase_version_test.xml 9df07ed
Diff: https://reviews.apache.org/r/44931/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 44931: Use Version Definition value for
package-version when installing
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44931/#review124012
-----------------------------------------------------------
Ship it!
ambari-common/src/main/python/resource_management/libraries/script/script.py (lines 283 - 287)
<https://reviews.apache.org/r/44931/#comment186365>
Seriously? Wow. This stuff needs a cleanup.
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java (line 359)
<https://reviews.apache.org/r/44931/#comment186367>
Let's add doc to this that says that it parses it the first time, but stores it after that.
- Jonathan Hurley
On March 17, 2016, 8:51 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44931/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 8:51 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-15447
> https://issues.apache.org/jira/browse/AMBARI-15447
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The version defintion file defines a package version that should be used when installing packages. The current calculation cannot be considered reliable, but should stay as a contingency for when NOT using a version definition.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py a8098a0
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 402a338
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e32e2f9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 07e62b3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1cd9c0a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 3398709
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 6bcedf5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java dea83a1
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80
> ambari-server/src/test/resources/hbase_version_test.xml 9df07ed
>
> Diff: https://reviews.apache.org/r/44931/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> Results :
>
> Tests run: 3965, Failures: 0, Errors: 0, Skipped: 33
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:10:59.814s
> [INFO] Finished at: Thu Mar 17 08:26:54 EDT 2016
> [INFO] Final Memory: 38M/566M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 44931: Use Version Definition value for
package-version when installing
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44931/#review124064
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 17, 2016, 12:51 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44931/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 12:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-15447
> https://issues.apache.org/jira/browse/AMBARI-15447
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The version defintion file defines a package version that should be used when installing packages. The current calculation cannot be considered reliable, but should stay as a contingency for when NOT using a version definition.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py a8098a0
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 402a338
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e32e2f9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 07e62b3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1cd9c0a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 3398709
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 6bcedf5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java dea83a1
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80
> ambari-server/src/test/resources/hbase_version_test.xml 9df07ed
>
> Diff: https://reviews.apache.org/r/44931/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> Results :
>
> Tests run: 3965, Failures: 0, Errors: 0, Skipped: 33
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:10:59.814s
> [INFO] Finished at: Thu Mar 17 08:26:54 EDT 2016
> [INFO] Final Memory: 38M/566M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 44931: Use Version Definition value for
package-version when installing
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44931/
-----------------------------------------------------------
(Updated March 17, 2016, 8:51 a.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-15447
https://issues.apache.org/jira/browse/AMBARI-15447
Repository: ambari
Description
-------
The version defintion file defines a package version that should be used when installing packages. The current calculation cannot be considered reliable, but should stay as a contingency for when NOT using a version definition.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py a8098a0
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 402a338
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e32e2f9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 07e62b3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1cd9c0a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 3398709
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 6bcedf5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java dea83a1
ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80
ambari-server/src/test/resources/hbase_version_test.xml 9df07ed
Diff: https://reviews.apache.org/r/44931/diff/
Testing (updated)
-------
Manual. Automated:
Results :
Tests run: 3965, Failures: 0, Errors: 0, Skipped: 33
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:10:59.814s
[INFO] Finished at: Thu Mar 17 08:26:54 EDT 2016
[INFO] Final Memory: 38M/566M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 44931: Use Version Definition value for
package-version when installing
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44931/
-----------------------------------------------------------
(Updated March 16, 2016, 6:08 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-15447
https://issues.apache.org/jira/browse/AMBARI-15447
Repository: ambari
Description
-------
The version defintion file defines a package version that should be used when installing packages. The current calculation cannot be considered reliable, but should stay as a contingency for when NOT using a version definition.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py a8098a0
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 402a338
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e32e2f9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 07e62b3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1cd9c0a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 3398709
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 6bcedf5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java dea83a1
ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80
ambari-server/src/test/resources/hbase_version_test.xml 9df07ed
Diff: https://reviews.apache.org/r/44931/diff/
Testing (updated)
-------
Manual. Automated:
Tests run: 3961, Failures: 0, Errors: 0, Skipped: 33
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 43:00.985s
[INFO] Finished at: Wed Mar 16 17:50:32 EDT 2016
[INFO] Final Memory: 35M/776M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole