You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/28 15:22:34 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

chia7712 commented on a change in pull request #9519:
URL: https://github.com/apache/kafka/pull/9519#discussion_r513527322



##########
File path: jmh-benchmarks/jmh.sh
##########
@@ -37,6 +37,6 @@ echo "gradle build done"
 
 echo "running JMH with args [$@]"
 
-java -jar ${libDir}/kafka-jmh-benchmarks-all.jar "$@"
+java -Xms256M -Xmx8G -jar ${libDir}/kafka-jmh-benchmarks-all.jar "$@"

Review comment:
       Does the new benchmark test need large memory? Could this change be replaced by jmh parameter (for example ```@Fork(jvmArgsAppend = "-Xmx8g")```)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org