Re: [PATCH] get-deps.sh zlib version number and file type changed

[Gabriela Gibson <ga...@gmail.com>]

On 30/04/13 18:27, Ben Reser wrote:

> 1) Need to avoid using GNU tar options on this.  Just like we don't
> use the j option to tar to deal with bzip2 we can't use the z option
> to deal with gzip.

Should this note be a comment in get-deps.sh?

Re: [PATCH] get-deps.sh zlib version number and file type changed

[Daniel Shahaf <da...@elego.de>]

Ben Reser wrote on Fri, May 03, 2013 at 22:41:37 -0700:
> On Fri, May 3, 2013 at 10:05 PM, Daniel Shahaf <da...@elego.de> wrote:
> > The same warning applies equally well to configure.ac and really to any
> > sh code we write for users to run.  I could see it lifted into the
> > coding style guidelines part of HACKING, for example.
> 
> Noted and adding to my todo list.

:-)

Re: [PATCH] get-deps.sh zlib version number and file type changed

[Ben Reser <be...@reser.org>]

On Fri, May 3, 2013 at 10:05 PM, Daniel Shahaf <da...@elego.de> wrote:
> The same warning applies equally well to configure.ac and really to any
> sh code we write for users to run.  I could see it lifted into the
> coding style guidelines part of HACKING, for example.

Noted and adding to my todo list.

Re: [PATCH] get-deps.sh zlib version number and file type changed

[Daniel Shahaf <da...@elego.de>]

Ben Reser wrote on Fri, May 03, 2013 at 13:00:10 -0700:
> On Wed, May 1, 2013 at 8:07 AM, Gabriela Gibson
> <ga...@gmail.com> wrote:
> > Should this note be a comment in get-deps.sh?
> 
> Done in r1478951.

The same warning applies equally well to configure.ac and really to any
sh code we write for users to run.  I could see it lifted into the
coding style guidelines part of HACKING, for example.

Re: [PATCH] get-deps.sh zlib version number and file type changed

[Ben Reser <be...@reser.org>]

On Wed, May 1, 2013 at 8:07 AM, Gabriela Gibson
<ga...@gmail.com> wrote:
> Should this note be a comment in get-deps.sh?

Done in r1478951.