[jira] [Commented] (KAFKA-4115) Grow default heap settings for distributed Connect from 256M to 1G

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376251#comment-16376251 ] 

ASF GitHub Bot commented on KAFKA-4115:
---------------------------------------

hachikuji closed pull request #1815: KAFKA-4115: grow default heap size for connect-distributed.sh to 1G
URL: https://github.com/apache/kafka/pull/1815
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/connect-distributed.sh b/bin/connect-distributed.sh
index 99cd27b4689..3f509c4544c 100755
--- a/bin/connect-distributed.sh
+++ b/bin/connect-distributed.sh
@@ -26,6 +26,10 @@ if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
     export KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/../config/connect-log4j.properties"
 fi
 
+if [ "x$KAFKA_HEAP_OPTS" = "x" ]; then
+    export KAFKA_HEAP_OPTS="-Xmx1G -Xms1G"
+fi
+
 EXTRA_ARGS=${EXTRA_ARGS-'-name connectDistributed'}
 
 COMMAND=$1


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Grow default heap settings for distributed Connect from 256M to 1G
> ------------------------------------------------------------------
>
>                 Key: KAFKA-4115
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4115
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>            Reporter: Shikhar Bhushan
>            Assignee: Arjun Satish
>            Priority: Major
>              Labels: newbie
>             Fix For: 1.1.0
>
>
> Currently, both {{connect-standalone.sh}} and {{connect-distributed.sh}} start the Connect JVM with the default heap settings from {{kafka-run-class.sh}} of {{-Xmx256M}}.
> At least for distributed connect, we should default to a much higher limit like 1G. While the 'correct' sizing is workload dependent, with a system where you can run arbitrary connector plugins which may perform buffering of data, we should provide for more headroom.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)