[GitHub] [dolphinscheduler] zwZjut commented on a change in pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task

[GitBox <gi...@apache.org>]

zwZjut commented on a change in pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683#discussion_r819325080



##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlParameters.java
##########
@@ -266,7 +266,7 @@ public void dealOutParam(String result) {
             //result only one line
             Map<String, String> firstRow = sqlResult.get(0);
             for (Property info : outProperty) {
-                info.setValue(String.valueOf(firstRow.get(info.getProp())));
+                info.setValue(String.valueOf(firstRow.get(info.getProp().toUpperCase())));

Review comment:
       what about the situtation 
     //if sql return more than one line ?  
   do you know where is the col name of result  set to UpperCase , is the loggic right?  if user need result of col a, we change it to col A, that is weired.  for example, select col_a from table_x,  I think we need return col_a instead of COL_A,  where the logic of col_a to COL_A should be modified.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org