You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2018/11/13 19:24:33 UTC

[GitHub] [geode] jinmeiliao opened pull request #2845: GEODE-4712 GEODE-5943: bounce vm after each test to fix flaky test

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2845: GEODE-4712 GEODE-5943: bounce vm after each test to fix flaky test

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Yesterday, Jinmei and I discovered that the JVM which goes critical and causes the failure has 12 GemFireCacheImpl instances in it. So this test seems to be hitting some sort of memory leak that needs to be fixed (not sure if it's a test or product leak).

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #2845: GEODE-4712 GEODE-5943: shut down the bucketSorter when destroying the partitioned region

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2845: GEODE-4712 GEODE-5943: shut down the bucketSorter when destroying the partitioned region

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.

This one should not be "BucketSorterRunnable". This is the thread name so the original "BucketSorterThread" was fine.

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2845: GEODE-4712 GEODE-5943: shut down the bucketSorter when destroying the partitioned region

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.

added the unit test and renamed the thread

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2845: GEODE-4712 GEODE-5943: shut down the bucketSorter when destroying the partitioned region

Posted by "agingade (GitHub)" <gi...@apache.org>.

Needs null check. Its created if the eviction is configured.

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2845: GEODE-4712 GEODE-5943: bounce vm after each test to fix flaky test

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.

@kirklund I talked to Eric about this. He thinks bouncing the VM should be the approach here. But I think there may be other ways as well. maybe we can pair on this to find a better approach. I know why this happened, but I am not sure what's the correct way to fix the flakiness.

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2845: GEODE-4712 GEODE-5943: shut down the bucketSorter when destroying the partitioned region

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.

added an integration test and renamed the thread

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2845: GEODE-4712 GEODE-5943: shut down the bucketSorter when destroying the partitioned region

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.

I unit test would be great but not required.

[ Full content available at: https://github.com/apache/geode/pull/2845 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org