You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/23 03:19:32 UTC

[GitHub] [incubator-doris] songchuangyuan opened a new pull request #6487: Submit Doris manager code

songchuangyuan opened a new pull request #6487:
URL: https://github.com/apache/incubator-doris/pull/6487


   ## Proposed changes
   
   All the codes of the current commercial version of Doris manager are uploaded, including unified cluster space management, user system, cluster monitoring and data construction.
   
   ## Types of changes
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
     1. Add user unified management and user authentication functions
     2. Add configuration unified management function
     3. Add Doris manager data construction function
     4. Add Doris manager monitoring operation and maintenance function
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
     1. The implementation mode of dm-server module accessing database is modified to use JPA.
     2. The problem that dm-server module and dm-agent depend on the same open source project version is not consistent has been corrected
   - [ ] Documentation Update (if none of the other choices apply)
     1. The API document is modified to remind users that they can view all API information through the swagger document after the manager server is started
     2. Added documentation for compilation and operation
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
     1. Three new modules have been added, general moudle,manager moudle and manager-server moudle
     2. general moulde, It includes the general functions of Doris manager, such as user management, authentication implementation and configuration management
     3. manager moudle,The core functions of Doris manager are realized, including Doris cluster monitoring, Doris cluster data construction and Doris cluster metadata synchronization
     4. manager-server moudle,The unified main entry function module of all modules compiles and survives an executable jar package containing all functions on the manger server side as the output package on the Doris manager server side. At the same time, because it needs to be integrated into the commercial Doris stack, the creation function of Doris cluster space in manager is also realized here. It also relies on the DM server module, and the functions of the DM server module are also included after the output of the startup package.
   - [ ] Optimization. Including functional usability improvements and performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
     1. The three newly added modules(general moudle,manager moudle and manager-server moudle) have written unit test code. It is recommended to pay attention to maintaining code quality in subsequent code submission
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #6487: Submit Doris manager code

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6487:
URL: https://github.com/apache/incubator-doris/pull/6487#discussion_r693630177



##########
File path: manager/dm-server/pom.xml
##########
@@ -18,26 +18,21 @@
         <java.version>1.8</java.version>
     </properties>
     <dependencies>
-        <dependency>
-            <groupId>org.springframework.boot</groupId>
-            <artifactId>spring-boot-starter-web</artifactId>
-        </dependency>
+<!--        <dependency>-->

Review comment:
       Remove unused code

##########
File path: manager/general/src/main/java/org/apache/doris/stack/exception/UserFailedLoginTooManyException.java
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.stack.exception;
+
+public class UserFailedLoginTooManyException extends Exception {
+
+    public static final String MESSAGE = "登录失败次数过多，五分钟后重试";

Review comment:
       English

##########
File path: manager/dm-server/src/main/resources/application.properties
##########
@@ -1,11 +1,11 @@
-server.port=9601
-
-spring.datasource.url = jdbc:mysql://localhost:3306/doris_manager?allowMultiQueries=true&useUnicode=true&characterEncoding=UTF-8&zeroDateTimeBehavior=convertToNull&useSSL=false&serverTimezone=GMT%2B8
-spring.datasource.username = root
-spring.datasource.password = password
-
-doris.manager.agent.install.dir = /usr/local/doris-manager
-doris.manager.agent.start-script = agent/bin/agent_start.sh
+#server.port=9601
+#
+#spring.datasource.url = jdbc:mysql://10.138.64.225:8306/test3?allowMultiQueries=true&useUnicode=true&characterEncoding=UTF-8&zeroDateTimeBehavior=convertToNull&useSSL=false&serverTimezone=GMT%2B8

Review comment:
       remove ip

##########
File path: manager/dm-server/src/main/java/org/apache/doris/stack/component/AgentComponent.java
##########
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.stack.component;
+
+import lombok.extern.slf4j.Slf4j;

Review comment:
       import order, please refer to `http://doris.incubator.apache.org/master/zh-CN/developer-guide/java-format-code.html#import-order`

##########
File path: manager/build.sh
##########
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash

Review comment:
       License header




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #6487: Submit Doris manager code

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6487:
URL: https://github.com/apache/incubator-doris/pull/6487


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org