You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2023/04/21 14:32:35 UTC

[superset] 01/01: chore(e2e): skip the worst offender of flaky tests.

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch skip-flaky-test
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 9b7d96c4fab89428a9c7d30aa20b4af9fb17cac3
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Fri Apr 21 08:32:24 2023 -0600

    chore(e2e): skip the worst offender of flaky tests.
---
 .../cypress-base/cypress/integration/dashboard/editmode.test.ts        | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
index d4e51046bc..113cf92d56 100644
--- a/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
+++ b/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
@@ -734,7 +734,8 @@ describe('Dashboard edit', () => {
       cy.getBySel('dashboard-charts-filter-search-input').clear();
     });
 
-    it('should disable the Save button when undoing', () => {
+    // TODO fix this test! This was the #1 flaky test as of 4/21/23 according to cypress dashboard.
+    xit('should disable the Save button when undoing', () => {
       cy.get('[role="checkbox"]').click();
       dragComponent('Unicode Cloud', 'card-title', false);
       cy.getBySel('header-save-button').should('be.enabled');