[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #1536:
URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r825964266



##########
File path: dockerfiles/Dockerfile-ubuntu
##########
@@ -16,14 +16,17 @@
 # specific language governing permissions and limitations
 # under the License.
 #
+
 # Copy this docker file to your local folder. Build the docker file like this - sudo docker build -t <username>/dispatch --file=Dockerfile-ubuntu . (don't miss the dot at the end)
 # To run it - sudo docker run -i -t <username>/dispatch (this will launch the dispatch router)
 
-# Gets the trusty Ubuntu from dockerhub
-FROM ubuntu:latest
+# Gets the Ubuntu from dockerhub
+FROM docker.io/library/ubuntu:focal

Review comment:
       Quick Q: Why do we need to include docker.io ? Can't we just say FROM ubuntu:focal ? I ran `podman search ubuntu --list-tags` and it looks like the only repo to house these ubuntu images is docker.io (for now). If any other repo houses these ubuntu images in the future, this can pull the image from there as well.
   
   Otherwise this PR looks good. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org