You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Reser <be...@reser.org> on 2003/11/27 10:34:24 UTC
[PATCH] packages for the various types in libsvn_client in Client.pm
* subversion/bindings/swig/perl/Client.pm
Packages that allow variables of the following types to be used
in object style in perl: (svn_client_commit_info_t,
svn_client_commit_item_t,
svn_client_ctx_t,
svn_client_proplist_item)
Also add my name to the AUTHORS section of Client.pm.
Index: subversion/bindings/swig/perl/Client.pm
===================================================================
--- subversion/bindings/swig/perl/Client.pm (revision 7861)
+++ subversion/bindings/swig/perl/Client.pm (working copy)
@@ -32,13 +50,24 @@
=cut
+package _p_svn_client_commit_info_t;
+use SVN::Base qw(Client svn_client_commit_info_t_);
+
+package _p_svn_client_commit_item_t;
+use SVN::Base qw(Client svn_client_commit_item_t_);
+
package _p_svn_client_ctx_t;
use SVN::Base qw(Client svn_client_ctx_t_);
+package _p_svn_client_proplist_item_t;
+use SVN::Base qw(Client svn_client_proplist_item_t_);
+
=head1 AUTHORS
Chia-liang Kao E<lt>clkao@clkao.orgE<gt>
+Ben Reser E<lt>ben@reser.orgE<gt>
+
=head1 COPYRIGHT
Copyright (c) 2003 CollabNet. All rights reserved.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] packages for the various types in libsvn_client in Client.pm
Posted by Ben Reser <be...@reser.org>.
On Sat, Nov 29, 2003 at 01:29:42PM -0500, Garrett Rooney wrote:
> svn_client_ctx_t support doesn't seem to be added by this patch, so it
> shouldn't be mentioned here.
Oops you're right. Got carried away with my list.
> I've also been wondering if it might make more sense if the client
> context got rolled into an SVN::Client object of some sort, so it can
> be created once and easily reused. The Client object could have
> methods that call the standard SVN::Client::foo functions and
> automatically pass in the appropriate client context. It seems
> conceptually clearer to me, but I'm not a big perl person, so I don't
> know if that makes sense or not.
I was going to do this. I just haven't gotten to it. I'm partly
waiting for the changes I've sent to be commited before I start making
more because if I need to make changes to my patches it'll be a real
pain to do so if I've made all kinds of other unrelated changes in the
files.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] packages for the various types in libsvn_client in Client.pm
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Nov 27, 2003, at 5:34 AM, Ben Reser wrote:
> * subversion/bindings/swig/perl/Client.pm
> Packages that allow variables of the following types to be used
> in object style in perl: (svn_client_commit_info_t,
> svn_client_commit_item_t,
> svn_client_ctx_t,
svn_client_ctx_t support doesn't seem to be added by this patch, so it
shouldn't be mentioned here.
I've also been wondering if it might make more sense if the client
context got rolled into an SVN::Client object of some sort, so it can
be created once and easily reused. The Client object could have
methods that call the standard SVN::Client::foo functions and
automatically pass in the appropriate client context. It seems
conceptually clearer to me, but I'm not a big perl person, so I don't
know if that makes sense or not.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] packages for the various types in libsvn_client in Client.pm
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Dec 13, 2003, at 5:16 AM, Ben Reser wrote:
> Still not applied here's a claned up version of this:
>
> * subversion/bindings/swig/perl/Client.pm
> Packages that allow variables of the following types to be used
> in object style in perl: (svn_client_commit_info_t,
> svn_client_commit_item_t,
> svn_client_proplist_item)
>
Committed in revision 8018, thanks!
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] packages for the various types in libsvn_client in Client.pm
Posted by Ben Reser <be...@reser.org>.
Still not applied here's a claned up version of this:
* subversion/bindings/swig/perl/Client.pm
Packages that allow variables of the following types to be used
in object style in perl: (svn_client_commit_info_t,
svn_client_commit_item_t,
svn_client_proplist_item)
Index: subversion/bindings/swig/perl/Client.pm
===================================================================
--- subversion/bindings/swig/perl/Client.pm (revision 7997)
+++ subversion/bindings/swig/perl/Client.pm (working copy)
@@ -32,9 +32,18 @@
=cut
+package _p_svn_client_commit_info_t;
+use SVN::Base qw(Client svn_client_commit_info_t_);
+
+package _p_svn_client_commit_item_t;
+use SVN::Base qw(Client svn_client_commit_item_t_);
+
package _p_svn_client_ctx_t;
use SVN::Base qw(Client svn_client_ctx_t_);
+package _p_svn_client_proplist_item_t;
+use SVN::Base qw(Client svn_client_proplist_item_t_);
+
=head1 AUTHORS
Chia-liang Kao E<lt>clkao@clkao.orgE<gt>
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org