[GitHub] [iceberg] rdblue commented on a diff in pull request #5364: Core, API: Support scanning from refs

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r985314477


##########
core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java:
##########
@@ -46,6 +46,14 @@ public TableScan asOfTime(long timestampMillis) {
             timestampMillis, context().fromSnapshotId(), context().toSnapshotId()));
   }
 
+  @Override
+  public TableScan useRef(String ref) {
+    throw new UnsupportedOperationException(

Review Comment:
   This seems fine for now, but we may have a case where we want incremental to be able to specify a branch. It doesn't matter currently because the snapshot IDs are always explicit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org