You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by rm...@apache.org on 2015/05/20 00:16:15 UTC
incubator-ranger git commit: Ranger-495: Coverity Scan for Apache
Ranger : - Null pointer issue on KnoxClient lookup manager
Repository: incubator-ranger
Updated Branches:
refs/heads/master afe001bb7 -> de5ea5421
Ranger-495: Coverity Scan for Apache Ranger : - Null pointer issue on KnoxClient lookup manager
Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/de5ea542
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/de5ea542
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/de5ea542
Branch: refs/heads/master
Commit: de5ea54217ffe910664e7844c7038876ecf76fa7
Parents: afe001b
Author: rmani <rm...@hortonworks.com>
Authored: Tue May 19 15:12:59 2015 -0700
Committer: rmani <rm...@hortonworks.com>
Committed: Tue May 19 15:15:39 2015 -0700
----------------------------------------------------------------------
.../apache/ranger/services/knox/client/KnoxResourceMgr.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/de5ea542/knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxResourceMgr.java
----------------------------------------------------------------------
diff --git a/knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxResourceMgr.java b/knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxResourceMgr.java
index cf551b9..34a3c40 100644
--- a/knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxResourceMgr.java
+++ b/knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxResourceMgr.java
@@ -101,9 +101,10 @@ public class KnoxResourceMgr {
}
final KnoxClient knoxClient = new KnoxConnectionMgr().getKnoxClient(knoxUrl, knoxAdminUser, knoxAdminPassword);
-
- synchronized(knoxClient) {
- resultList = KnoxClient.getKnoxResources(knoxClient, knoxTopologyName, knoxServiceName,knoxTopologyList,knoxServiceList);
+ if ( knoxClient != null) {
+ synchronized(knoxClient) {
+ resultList = KnoxClient.getKnoxResources(knoxClient, knoxTopologyName, knoxServiceName,knoxTopologyList,knoxServiceList);
+ }
}
return resultList;
}